Add support for dimension fields #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
mtojek
reviewed
Oct 20, 2021
| @@ -31,18 +33,18 @@ type field struct { | |||
| func ValidateFieldGroups(pkgRoot string) ve.ValidationErrors { | |||
There was a problem hiding this comment.
Originally this function (and whole file) was designed to check field group properties. See comment.
Does validation logic of dimensions apply to ordinary, single fields? Maybe it's worth extracting it to a separate .go file?
There was a problem hiding this comment.
Oh, good point, yes, I will separate it.
There was a problem hiding this comment.
Split in 26292de, this would be ready for another review.
mtojek
previously approved these changes
Oct 25, 2021
versions/1/changelog.yml
Outdated
| @@ -4,6 +4,9 @@ | |||
| ## | |||
| - version: 1.2.1-next | |||
| changes: | |||
| - description: Add support for dimension fields. | |||
There was a problem hiding this comment.
nit: new changes go to the bottom :)
mtojek
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
dimensionparameter to fields, so they can be defined as dimensions for time series data. Dimensions are used to identify time series. For a data stream, events with the same set of dimensions are considered the same time serie. Only keywords, ips and numeric values can be defined as dimensions, this is enforced by the spec.Why is it important?
There is an effort in Elasticsearch to improve the support of time series data (see elastic/elasticsearch#74014, elastic/elasticsearch#74450, elastic/elasticsearch#74660). As part of this, dimensions are going to be first-class citizens, what will have advantages when storing and consuming time series data. To leverage these features in integrations, their dimensions should be properly defined.
Checklist
test/packagesthat prove my change is effective.versions/N/changelog.yml.Related issues