This repository has been archived by the owner on Jan 27, 2023. It is now read-only.
Add base-fields.yml files #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
|
thomasneirynck
pushed a commit
to thomasneirynck/package-storage
that referenced
this pull request
Sep 28, 2021
This changes the current icon path from `/img/{package}-{version}/icon.png` to `/package/{package}-{version}/img/icon.png`. The reasoning is that directly the assets from the package itself are served so no special handlers are needed in the backend. The other breaking change is that in case no icon exists, a 404 is returned instead of the default icon. It's up the integrations manager to decide what to do for a default icon.
With elastic/package-registry#45 the API response for icons will be refactored. For now I left the API response the same, meaning it contains the icon path even if no icon exists, but will change that when tackling elastic#45.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds mandatory
base-fields.ymlfiles.It's a next step in elastic/package-registry#465 (comment)