-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new track for tsdb based on k8s integration #373
Conversation
…l ordinal loading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, thank you. I left some README suggestions and have not executed the track yet.
Can you add track parameters for number_of_shards
and number_of_replicas
, if it makes sense to do so?
Co-authored-by: Jason Bryan <[email protected]>
Co-authored-by: Jason Bryan <[email protected]>
Co-authored-by: Jason Bryan <[email protected]>
Co-authored-by: Jason Bryan <[email protected]>
Thanks for taking a look @inqueue. I updated the track.
I think it makes sense and I added the track params. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great and awesome amount of work, thank you!
I have been able to run this benchmark (it's ongoing, will report when it succeeds).
Left a suggestion to clarify a little about what the touch-...
tasks are doing and also clarify some sentences in the readme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Left two comments, one for a minor typo, and another for a suggestion to move all the variables in track.json
for better discoverability. Up to you if you want to implement the suggestion.
@@ -0,0 +1,1085 @@ | |||
{% set end_time = "2023-05-16T21:00:00.000Z" %} | |||
{% set time_intervals = {"15_minutes": ["30s", "2023-05-16T20:45:00.000Z"], "2_hours": ["1m", "2023-05-16T19:00:00.000Z"], "24_hours": ["30m", "2023-05-15T21:00:00.000Z"]} %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above two seem to be used also in challenges/default.json
; does it make more sense to move them, as well as the variables from challenges/default.json
:
{% set search_iterations = 20 %}
{% set search_warmup_iterations = 50 %}
{% set target_interval = 4 %}
to a centralized place, e.g. at the top of track.json
(right after {% import "rally.helpers" as rally with context %}
) for better discoverability? If you choose to do that, remember to update the references in README.md
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me. I will update this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me. I will update this PR.
LGTM also after 5ea2206
Co-authored-by: Dimitrios Liappis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This track indexes generated k8s pod and k8s container data based on the k8s integration and then test performance of searches that are based on k8s integration visualisations. See README for more details.
This track indexes generated k8s pod and k8s container data based on the k8s integration and then test performance of searches that are based on k8s integration visualisations. See README for more details.