Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Lens Visualization Plugin Available for Cases #1018

Merged
merged 10 commits into from
Sep 21, 2021

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Sep 8, 2021

Addresses #1017.

Preview here.

@nastasha-solomon nastasha-solomon added Team: Docs v7.15.0 Feature: RAC Issues that affect the RAC (Rules, Alerts, Cases) initiative labels Sep 8, 2021
@nastasha-solomon nastasha-solomon self-assigned this Sep 8, 2021
@nastasha-solomon nastasha-solomon marked this pull request as ready for review September 10, 2021 15:11
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few phrasing comments, otherwise LGTM!

docs/cases/cases-overview.asciidoc Outdated Show resolved Hide resolved
docs/cases/cases-overview.asciidoc Outdated Show resolved Hide resolved
docs/cases/cases-overview.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few very slight suggestions.

@manishgupta-qasource - this is ready for QA review. Thanks!

docs/cases/cases-overview.asciidoc Outdated Show resolved Hide resolved
docs/cases/cases-overview.asciidoc Outdated Show resolved Hide resolved
@jmikell821 jmikell821 added the readyforQA PRs that are ready for QA review. label Sep 14, 2021
@ghost
Copy link

ghost commented Sep 16, 2021

Hi @nastasha-solomon

we have validated the above shared preview doc link and found some of the changes to be done .

Please find the details for the same
#1053

Thanks !!!

c.c. @jmikell821

@nastasha-solomon
Copy link
Contributor Author

@deepikakeshav-qasource thanks for finding this! I removed the items you pointed out in #1053 and committed those changes, so you should see them here soon!

@ghost ghost added QA:Validated Issue has been Validated by QA Team and removed readyforQA PRs that are ready for QA review. labels Sep 21, 2021
@nastasha-solomon nastasha-solomon merged commit 7a2f6de into main Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: RAC Issues that affect the RAC (Rules, Alerts, Cases) initiative QA:Validated Issue has been Validated by QA Team Team: Docs v7.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants