-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs]Updates ToC - API and Reference Sections #18
[Docs]Updates ToC - API and Reference Sections #18
Conversation
e5a1da6
to
f2925d6
Compare
@angorayc - this is the file (timeline schema) I want to finalise first: https://github.com/elastic/security-docs/pull/18/files#diff-096d4f209a384c835f720d067fef1abf After that, documenting the API should be straightforward. Thanks |
ae70155
to
6fe9af1
Compare
6fe9af1
to
6755418
Compare
|============================================== | ||
|Name |Type |Description | ||
|
||
|`aggregatable` |Boolean |??? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.elastic.co/guide/en/elasticsearch/reference/current/search-field-caps.html#search-field-caps-api-response-body
Whether this field can be aggregated on all indices.
|`columnHeaderType` |String |??? | ||
|`description` |String |??? | ||
|`example` |String |??? | ||
|`indexes` |String |??? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same as indices
in https://www.elastic.co/guide/en/elasticsearch/reference/current/search-field-caps.html#search-field-caps-api-response-body
The list of indices where this field has the same type, or null if all indices have the same type for the field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Array?
|`description` |String |??? | ||
|`example` |String |??? | ||
|`indexes` |String |??? | ||
|`id` |String |??? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alias of actual field from ECS or user defined field name
|`example` |String |??? | ||
|`indexes` |String |??? | ||
|`id` |String |??? | ||
|`name` |String |??? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typically null, this field is reserved for future use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angorayc - should we remove this for now?
|`id` |String |??? | ||
|`name` |String |??? | ||
|`placeholder` |String |??? | ||
|`searchable` |Boolean |??? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.elastic.co/guide/en/elasticsearch/reference/current/search-field-caps.html#search-field-caps-api-response-body
Whether this field is indexed for search on all indices.
|`excluded` |Boolean |Indicates if the dropzone query clause uses `NOT` logic. | ||
|`id` |String |The dropzone query clause's unique ID. | ||
|`kqlQuery` |String |Always an empty string (not used).??? | ||
// Can be removed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are following some reusable schema across Kibana, therefore we can sometimes find the property is there but we are not actually using it.
@angorayc @XavierM @jmikell821 @Donnater Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
One question I had when looking at the document was whether we needed a callout for the "Pin"? I see that the pinned event ID's show up under the kqlQuery object.
* starts adding timeline api and object schema * continues timeline object schema * timeline schema * minor edits * another correction * corrections - round 1 * table structure * correction cont * adds screenshot * fixes terminology * wording * wording * more corrections and stuff * more stuff * LIVERPOOL 30 YEARS * improves screenshot callouts * corrections are meeting * fixes link * restrcuture ToC * cleanup * improves pinned events description * removes timeline schema file text
* starts adding timeline api and object schema * continues timeline object schema * timeline schema * minor edits * another correction * corrections - round 1 * table structure * correction cont * adds screenshot * fixes terminology * wording * wording * more corrections and stuff * more stuff * LIVERPOOL 30 YEARS * improves screenshot callouts * corrections are meeting * fixes link * restrcuture ToC * cleanup * improves pinned events description * removes timeline schema file text
Moves the API and ref sections to first-level chapters.
Adds Timeline API object schema.Timeline schema previewAll other changes are just for restructuring the new Elastic Security docs ToC, and they do not need to be reviewed.