Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]Updates ToC - API and Reference Sections #18

Merged
merged 22 commits into from
Jul 5, 2020

Conversation

benskelker
Copy link
Contributor

@benskelker benskelker commented Jun 15, 2020

Moves the API and ref sections to first-level chapters.

Adds Timeline API object schema.

Timeline schema preview

All other changes are just for restructuring the new Elastic Security docs ToC, and they do not need to be reviewed.

@benskelker benskelker changed the title [Docs]Starts adding timeline api and object schema [Docs]Documents Timeline API and object schema Jun 15, 2020
@benskelker benskelker force-pushed the timeline-api-and-object-schema branch from e5a1da6 to f2925d6 Compare June 16, 2020 05:04
@benskelker benskelker requested review from XavierM and angorayc June 16, 2020 14:12
@benskelker
Copy link
Contributor Author

@angorayc - this is the file (timeline schema) I want to finalise first: https://github.com/elastic/security-docs/pull/18/files#diff-096d4f209a384c835f720d067fef1abf

After that, documenting the API should be straightforward. Thanks

@benskelker benskelker force-pushed the timeline-api-and-object-schema branch from ae70155 to 6fe9af1 Compare June 17, 2020 06:32
@benskelker benskelker force-pushed the timeline-api-and-object-schema branch from 6fe9af1 to 6755418 Compare June 18, 2020 08:01
|==============================================
|Name |Type |Description

|`aggregatable` |Boolean |???
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|`columnHeaderType` |String |???
|`description` |String |???
|`example` |String |???
|`indexes` |String |???
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same as indices in https://www.elastic.co/guide/en/elasticsearch/reference/current/search-field-caps.html#search-field-caps-api-response-body
The list of indices where this field has the same type, or null if all indices have the same type for the field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Array?

|`description` |String |???
|`example` |String |???
|`indexes` |String |???
|`id` |String |???
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alias of actual field from ECS or user defined field name

|`example` |String |???
|`indexes` |String |???
|`id` |String |???
|`name` |String |???
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typically null, this field is reserved for future use

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angorayc - should we remove this for now?

|`id` |String |???
|`name` |String |???
|`placeholder` |String |???
|`searchable` |Boolean |???
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|`excluded` |Boolean |Indicates if the dropzone query clause uses `NOT` logic.
|`id` |String |The dropzone query clause's unique ID.
|`kqlQuery` |String |Always an empty string (not used).???
// Can be removed?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are following some reusable schema across Kibana, therefore we can sometimes find the property is there but we are not actually using it.

@benskelker benskelker changed the title [Docs]Documents Timeline API and object schema [Docs]Documents Timeline object schema Jul 2, 2020
@benskelker benskelker requested review from narcher7 and jmikell821 July 2, 2020 08:12
@benskelker benskelker marked this pull request as ready for review July 2, 2020 08:24
@benskelker
Copy link
Contributor Author

@angorayc @XavierM @jmikell821 @Donnater
As this makes changes to the new Security Docs ToC, I'd like to get this merged ASAP and then open a separate PR for the Timeline API.
The only file that needs reviewing is https://github.com/elastic/security-docs/pull/18/files#diff-096d4f209a384c835f720d067fef1abf

Thanks!

@benskelker benskelker requested a review from MikePaquette July 2, 2020 08:44
@benskelker benskelker added the v7.9.0 Features in the 7.9 Release label Jul 2, 2020
Copy link
Contributor

@MikePaquette MikePaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
One question I had when looking at the document was whether we needed a callout for the "Pin"? I see that the pinned event ID's show up under the kqlQuery object.

@benskelker benskelker merged commit 9d5eefc into elastic:master Jul 5, 2020
@benskelker benskelker changed the title [Docs]Documents Timeline object schema [Docs]Updates ToC API and Reference Sections Jul 5, 2020
benskelker added a commit to benskelker/security-docs that referenced this pull request Jul 5, 2020
* starts adding timeline api and object schema

* continues timeline object schema

* timeline schema

* minor edits

* another correction

* corrections - round 1

* table structure

* correction cont

* adds screenshot

* fixes terminology

* wording

* wording

* more corrections and stuff

* more stuff

* LIVERPOOL 30 YEARS

* improves screenshot callouts

* corrections are meeting

* fixes link

* restrcuture ToC

* cleanup

* improves pinned events description

* removes timeline schema file text
benskelker added a commit that referenced this pull request Jul 5, 2020
* starts adding timeline api and object schema

* continues timeline object schema

* timeline schema

* minor edits

* another correction

* corrections - round 1

* table structure

* correction cont

* adds screenshot

* fixes terminology

* wording

* wording

* more corrections and stuff

* more stuff

* LIVERPOOL 30 YEARS

* improves screenshot callouts

* corrections are meeting

* fixes link

* restrcuture ToC

* cleanup

* improves pinned events description

* removes timeline schema file text
@benskelker benskelker deleted the timeline-api-and-object-schema branch July 5, 2020 07:48
@benskelker
Copy link
Contributor Author

@angorayc @XavierM - changed this PR to make structural changes only. Timeline schema and API moved to: #50

@benskelker benskelker changed the title [Docs]Updates ToC API and Reference Sections [Docs]Updates ToC - API and Reference Sections Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v7.9.0 Features in the 7.9 Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants