-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Known issue][Detection Engine][8.16.0 & 8.16.1] Exception item comment validation on newline chars #6280
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nastasha-solomon I had a few suggestions; they apply to both sections but I didn't duplicate the suggested changes. Let me know if you have any questions.
Co-authored-by: Ryland Herrick <[email protected]>
Co-authored-by: Ryland Herrick <[email protected]>
Co-authored-by: Ryland Herrick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding markup, links, and much-needed grammar here! LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, thank you! Left one minor comment.
…nt validation on newline chars (#6280) * First draft * Minor tweaks * missing word * Grammar * More small tweaks * Ryland's input * Small fixes * Cleanup * Update docs/release-notes/8.16.asciidoc Co-authored-by: Ryland Herrick <[email protected]> * Update docs/release-notes/8.16.asciidoc Co-authored-by: Ryland Herrick <[email protected]> * Update docs/release-notes/8.16.asciidoc Co-authored-by: Ryland Herrick <[email protected]> * Update docs/release-notes/8.16.asciidoc * Formatting fixes * fixes sample commands * Update docs/release-notes/8.16.asciidoc * Update docs/release-notes/8.16.asciidoc * Update docs/release-notes/8.16.asciidoc * Updates last step * Adds fix info * Removes fix details --------- Co-authored-by: Ryland Herrick <[email protected]> (cherry picked from commit f0d60d6)
…nt validation on newline chars (#6280) * First draft * Minor tweaks * missing word * Grammar * More small tweaks * Ryland's input * Small fixes * Cleanup * Update docs/release-notes/8.16.asciidoc Co-authored-by: Ryland Herrick <[email protected]> * Update docs/release-notes/8.16.asciidoc Co-authored-by: Ryland Herrick <[email protected]> * Update docs/release-notes/8.16.asciidoc Co-authored-by: Ryland Herrick <[email protected]> * Update docs/release-notes/8.16.asciidoc * Formatting fixes * fixes sample commands * Update docs/release-notes/8.16.asciidoc * Update docs/release-notes/8.16.asciidoc * Update docs/release-notes/8.16.asciidoc * Updates last step * Adds fix info * Removes fix details --------- Co-authored-by: Ryland Herrick <[email protected]> (cherry picked from commit f0d60d6)
…m comment validation on newline chars (backport #6280) (#6312) * First draft * Minor tweaks * missing word * Grammar * More small tweaks * Ryland's input * Small fixes * Cleanup * Update docs/release-notes/8.16.asciidoc Co-authored-by: Ryland Herrick <[email protected]> * Update docs/release-notes/8.16.asciidoc Co-authored-by: Ryland Herrick <[email protected]> * Update docs/release-notes/8.16.asciidoc Co-authored-by: Ryland Herrick <[email protected]> * Update docs/release-notes/8.16.asciidoc * Formatting fixes * fixes sample commands * Update docs/release-notes/8.16.asciidoc * Update docs/release-notes/8.16.asciidoc * Update docs/release-notes/8.16.asciidoc * Updates last step * Adds fix info * Removes fix details --------- Co-authored-by: Ryland Herrick <[email protected]> (cherry picked from commit f0d60d6) Co-authored-by: Nastasha Solomon <[email protected]>
…m comment validation on newline chars (backport #6280) (#6311) * First draft * Minor tweaks * missing word * Grammar * More small tweaks * Ryland's input * Small fixes * Cleanup * Update docs/release-notes/8.16.asciidoc Co-authored-by: Ryland Herrick <[email protected]> * Update docs/release-notes/8.16.asciidoc Co-authored-by: Ryland Herrick <[email protected]> * Update docs/release-notes/8.16.asciidoc Co-authored-by: Ryland Herrick <[email protected]> * Update docs/release-notes/8.16.asciidoc * Formatting fixes * fixes sample commands * Update docs/release-notes/8.16.asciidoc * Update docs/release-notes/8.16.asciidoc * Update docs/release-notes/8.16.asciidoc * Updates last step * Adds fix info * Removes fix details --------- Co-authored-by: Ryland Herrick <[email protected]> (cherry picked from commit f0d60d6) Co-authored-by: Nastasha Solomon <[email protected]>
Partially addresses #6275 by updating the 8.16.0 and 8.16.1 release notes. This will be doc'd as a known issue for 8.17 in #6224.
Preview: 8.16.x release notes