Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Moves feature importance out from the shared file to a standalone page #1004

Merged
merged 5 commits into from
Apr 27, 2020
Merged

[DOCS] Moves feature importance out from the shared file to a standalone page #1004

merged 5 commits into from
Apr 27, 2020

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Apr 21, 2020 •
edited
Loading

Overview

This PR achieves the following:

  • moves the text about feature importance to a standalone page,
  • creates a new Further readings section on the page that contains a link to the blog post about feature importance,
  • adds the new page under the Concepts section in the ML DFA book,
  • deletes shared-ml-concepts.asciidoc as feature importance was the only concept there,
  • adds a short sentence about feature importance to both the classification and the regression docs and a link that points to the new page.

Preview

Feature importance
Classification
Regression

@szabosteve szabosteve requested a review from lcawl April 21, 2020 08:35
@szabosteve szabosteve mentioned this pull request Apr 21, 2020
Merged
@szabosteve szabosteve merged commit 2f5349c into elastic:master Apr 27, 2020
@szabosteve szabosteve deleted the split.feature.imp branch April 27, 2020 16:01
szabosteve added a commit to szabosteve/stack-docs that referenced this pull request Apr 27, 2020
@szabosteve @lcawl
[DOCS] Moves feature importance out from the shared file to a standal…
90ac362 
…one page (elastic#1004)

Co-authored-by: Lisa Cawley <[email protected]>
szabosteve added a commit to szabosteve/stack-docs that referenced this pull request Apr 27, 2020
@szabosteve @lcawl
[DOCS] Moves feature importance out from the shared file to a standal…
52326f6 
…one page (elastic#1004)

Co-authored-by: Lisa Cawley <[email protected]>
@szabosteve
Copy link
Contributor Author

Backport commits:
7.x: 90ac362
7.7: 52326f6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcawl lcawl lcawl left review comments

Assignees
No one assigned
Labels
:ml v7.7.1 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szabosteve @lcawl