Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new reference architectures #2889

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

georgewallace
Copy link
Contributor

No description provided.

@georgewallace georgewallace requested a review from a team as a code owner December 4, 2024 22:37
Copy link

github-actions bot commented Dec 4, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Dec 4, 2024

This pull request does not have a backport label. Could you fix it @georgewallace? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip automated backport with mergify label Dec 4, 2024
@georgewallace
Copy link
Contributor Author

@karenzone I have the content where it needs to be now. Mind giving a quick review? Once this is merged I will work on the PR to update the build.

@karenzone karenzone self-requested a review January 3, 2025 16:37
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on visual inspection 🚀
The real test comes when buildkite runs on your docs PR. So exciting!

@georgewallace georgewallace merged commit 76459b9 into elastic:main Jan 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants