Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sparse embedding models to list of compatible models #2901

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

davidkyle
Copy link
Member

With the change in elastic/eland#740 Eland now supports uploading 3rd party sparse embedding models (other than ELSER). This PR adds some models to the list of known compatible models.

The Eland command to install one of these models must use the text_expansion task type

eland_import_hub_model \
      --url 'http://localhost:9200' \
      -u elastic-admin -p elastic-password \
      --hub-model-id 'hotchpotch/japanese-splade-base-v1' \
      --task-type text_expansion 

@davidkyle davidkyle added the backport-8.17 Automated backport with mergify label Jan 6, 2025
@davidkyle davidkyle requested a review from a team as a code owner January 6, 2025 11:57
Copy link

github-actions bot commented Jan 6, 2025

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@davidkyle davidkyle requested a review from szabosteve January 6, 2025 11:57
szabosteve
szabosteve previously approved these changes Jan 6, 2025
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this addition, LGTM!

Copy link

@daixque daixque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but just dropped one comment.

docs/en/stack/ml/nlp/ml-nlp-model-ref.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidkyle davidkyle merged commit e94b4fe into elastic:main Jan 8, 2025
3 checks passed
mergify bot pushed a commit that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.17 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants