Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Creates a data frame examples page #389

Merged
merged 33 commits into from
Jul 2, 2019

Conversation

szabosteve
Copy link
Contributor

This PR creates a data frame examples page under data-frames and indicates it in the index file.

@szabosteve szabosteve mentioned this pull request Jun 26, 2019
2 tasks
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few more minor comments, but otherwise it LGTM!

Copy link

@sophiec20 sophiec20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 2 changes requested.

For discussion - do you think we need to show an example of the source document? or a relevant fragment of the source document? It would make the examples clearer but might take up too much vertical space and detract from the read-ability of the example.

docs/en/stack/data-frames/dataframe-examples.asciidoc Outdated Show resolved Hide resolved
docs/en/stack/data-frames/dataframe-examples.asciidoc Outdated Show resolved Hide resolved
@szabosteve szabosteve merged commit aec5eaf into elastic:master Jul 2, 2019
@szabosteve szabosteve deleted the df-examples branch July 2, 2019 08:53
szabosteve added a commit that referenced this pull request Jul 2, 2019
This PR creates a data frame examples page under data-frames and indicates it in the index file.
szabosteve added a commit that referenced this pull request Jul 2, 2019
This PR creates a data frame examples page under data-frames and indicates it in the index file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants