-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Creates a data frame examples page #389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few more minor comments, but otherwise it LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with 2 changes requested.
For discussion - do you think we need to show an example of the source document? or a relevant fragment of the source document? It would make the examples clearer but might take up too much vertical space and detract from the read-ability of the example.
This PR creates a data frame examples page under data-frames and indicates it in the index file.
This PR creates a data frame examples page under data-frames and indicates it in the index file.
This PR creates a data frame examples page under data-frames and indicates it in the index file.