Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for AWS provider SHA error #867

Merged

Conversation

GeorgeGkinis
Copy link
Contributor

Description

Workaround for hashicorp/terraform-provider-aws#39676
Currently Git tests fail with version v5.71.0 and as such no merges are possible to the ec provider main branch.

Related Issues

Motivation and Context

We need to be able to merge.

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@GeorgeGkinis GeorgeGkinis requested a review from a team as a code owner October 11, 2024 12:33
@GeorgeGkinis
Copy link
Contributor Author

@dimuon Can you run the unit tests to see if this works?

@GeorgeGkinis
Copy link
Contributor Author

@dimuon I fixed the lint error.

@dimuon
Copy link
Contributor

dimuon commented Oct 11, 2024

@GeorgeGkinis , did you push the fix for the lint error?

@GeorgeGkinis
Copy link
Contributor Author

GeorgeGkinis commented Oct 11, 2024

@dimuon I did, but just now....
Try again please?

@dimuon dimuon merged commit 05c650a into elastic:master Oct 11, 2024
2 checks passed
@GeorgeGkinis
Copy link
Contributor Author

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants