Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Make backend iterator class support an infinite size option #119

Closed
justinkambic opened this issue Nov 25, 2019 · 0 comments · Fixed by elastic/kibana#55931
Closed

[Uptime] Make backend iterator class support an infinite size option #119

justinkambic opened this issue Nov 25, 2019 · 0 comments · Fixed by elastic/kibana#55931
Assignees
@andrewvc
Labels
enhancement New feature or request

Comments

@justinkambic
Copy link

Is your feature request related to a problem? Please describe.
In elastic/kibana#48035 we introduced a very high constant value to ensure we chunk up all the monitors while counting them. It would be cleaner to patch the iterator code itself so we don't have to maintain this weird constant default.

Describe the solution you'd like
Remove the existing constant value and have the iterator support an infinite size option.

Describe alternatives you've considered
We've implemented the alternative solution.

Additional context
N/A
@justinkambic justinkambic added the enhancement New feature or request label Nov 25, 2019
@andrewvc andrewvc self-assigned this Jan 24, 2020
andrewvc added a commit to andrewvc/kibana that referenced this issue Jan 24, 2020
@andrewvc
[Uptime] Simplify snapshot max to Infinity
9a8e0f0 
Fixes elastic/uptime#119

Rather than relying on a contant for the max number of monitors, it's
easier to just use infinity. This is simpler than making the iterator
more complex with an 'infinite' mode.
@andrewvc andrewvc mentioned this issue Jan 24, 2020
Merged
andrewvc added a commit to elastic/kibana that referenced this issue Jan 27, 2020
@andrewvc @elasticmachine
[Uptime] Simplify snapshot max to Infinity (#55931)
35603c8 
Fixes elastic/uptime#119

Rather than relying on a contant for the max number of monitors, it's
easier to just use infinity. This is simpler than making the iterator
more complex with an 'infinite' mode.

Co-authored-by: Elastic Machine <[email protected]>
andrewvc added a commit to andrewvc/kibana that referenced this issue Jan 27, 2020
@andrewvc @elasticmachine
[Uptime] Simplify snapshot max to Infinity (elastic#55931)
55aa850 
Fixes elastic/uptime#119

Rather than relying on a contant for the max number of monitors, it's
easier to just use infinity. This is simpler than making the iterator
more complex with an 'infinite' mode.

Co-authored-by: Elastic Machine <[email protected]>
andrewvc added a commit to elastic/kibana that referenced this issue Jan 28, 2020
@andrewvc @elasticmachine
[Uptime] Simplify snapshot max to Infinity (#55931) (#56064)
0c5c054 
Fixes elastic/uptime#119

Rather than relying on a contant for the max number of monitors, it's
easier to just use infinity. This is simpler than making the iterator
more complex with an 'infinite' mode.

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewvc andrewvc

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Uptime] Simplify snapshot max to Infinity andrewvc/kibana
2 participants
@andrewvc @justinkambic