Added maester-library to re-assembling messages action #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A3a3e1
reviewed
Jul 12, 2021
| return JSON.parse(bucket); | ||
| } | ||
|
|
||
| async createBucketIfNotExists(externalId, bucketSize) { |
There was a problem hiding this comment.
Are these objects buckets in fact? I guess names should be changed here
A3a3e1
reviewed
Jul 12, 2021
package.json
Outdated
| @@ -16,6 +16,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@elastic.io/component-commons-library": "1.1.4", | |||
| "@elastic.io/maester-client": "3.3.0-dev.1", | |||
A3a3e1
requested changes
Jul 12, 2021
…ent into adding-maester
A3a3e1
reviewed
Jul 12, 2021
CHANGELOG.md
Outdated
| @@ -1,3 +1,6 @@ | |||
| ## 1.2.1 (July 12, 2021) | |||
| * Added possibility to save data from the individual messages to maester storage (using maester-client library v3.3.0) and reassemble these messages later | |||
There was a problem hiding this comment.
Suggested change
| * Added possibility to save data from the individual messages to maester storage (using maester-client library v3.3.0) and reassemble these messages later | |
| * Added possibility to save data from the individual messages to maester storage (using maester-client library 3.3.0) and reassemble these messages later |
A3a3e1
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.