Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional message #78

Merged
merged 5 commits into from
Nov 24, 2021
Merged

Conversation

FranckTala
Copy link
Contributor

@jhorbulyk Please review

@FranckTala FranckTala requested a review from jhorbulyk November 9, 2021 08:35
Copy link
Contributor

@jhorbulyk jhorbulyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll do QA in our next sprint.

@stas-fomenko
Copy link
Contributor

I'm getting 4 different msgs as output like:

{"groupSize":1,"groupId":"2021-11-15T16:31:08.947Z","messageData":[1]}

and no random guid appears as a key for msg, it's just 1 array with 1 item (incoming message value that I expect from previous step) in it

NOTES:
Input for re-assemble:

{
  "messageData": 1, mapped from step 3
  "groupId": "2095-06-25T19:39:55.874Z" mapped from trigger
}

(test flow is: simple trigger -> config component where I emit

[
  {
    "a": 1
  },
  {
    "a": 2
  },
  {
    "a": 3
  },
  {
    "a": 4
  }
]

-> splitter (split into 4 messages))

package.json Outdated
@@ -19,7 +19,8 @@
"@elastic.io/maester-client": "3.3.0",
"elasticio-node": "0.0.9",
"elasticio-sailor-nodejs": "2.6.24",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls upgrade "elasticio-sailor-nodejs": "2.6.24", -> "elasticio-sailor-nodejs": "2.6.26",

@stas-fomenko stas-fomenko changed the base branch from master to upd-sailor November 24, 2021 20:45
@stas-fomenko stas-fomenko merged commit de3e82e into elasticio:upd-sailor Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants