-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change some messages and documentation to Welkin, as part of our rebranding #2424
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changes so stuff works without redirects!
I see the addition of the Registered Trademark symbol. If we use that, we ought to ensure that we always write it as "Elastisys Welkin®", because our registered trademark is actually for those two words -- the Elastisys part is required as well.
Edit: is it possible to set something like that up using the "vale" or whatever the not-a-spellchecker-but-almost tool is called?
Thanks!
Nice catch. Fixed!
In my experience, Vale is rather bad at "multi-word" spellchecking. I added a custom pre-commit hook. |
d1b4626
to
1eb238f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: linus-astrom <[email protected]>
Co-authored-by: André Arnqvist <[email protected]>
Co-authored-by: André Arnqvist <[email protected]>
Co-authored-by: André Arnqvist <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice to see more of the branding being updated 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, a lot of really good changes that are also visible to Application Developers! Love it!
Warning
This is a public repository, ensure not to disclose:
What kind of PR is this?
Required: Mark one of the following that is applicable:
Optional: Mark one or more of the following that are applicable:
Important
Breaking changes should be marked
kind/admin-change
orkind/dev-change
depending on typeCritical security fixes should be marked with
kind/security
Release notes
Change some messages and documentation to Welkin, as part of our rebranding
What does this PR do / why do we need this PR?
The purpose of this PR is for me to test how simple it is to use the instructions in DEVELOPMENT.md to make a simple improvement to Welkin.
As a side-effect, I decided to actually contribute. 😄
Information to reviewers
Checklist