-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apps: gatekeeper policy to reject pods without controller #2429
base: vf/emptydir-policy
Are you sure you want to change the base?
Conversation
Basing this on vf/emptydir-policy for now, to make development easier for me while I'm working on both. Will point this towards main when the first branch is merged. |
helmfile.d/charts/gatekeeper/templates/policies/reject-pod-without-controller.rego
Outdated
Show resolved
Hide resolved
helmfile.d/charts/gatekeeper/templates/policies/reject-pod-without-controller.rego
Outdated
Show resolved
Hide resolved
helmfile.d/charts/gatekeeper/templates/policies/tests/reject-pod-without-controller.rego
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only one small question regarding the annotation
helmfile.d/charts/gatekeeper/templates/policies/reject-pod-without-controller.rego
Show resolved
Hide resolved
config/schemas/config.yaml
Outdated
Configure constraint to reject pods without a controller. | ||
|
||
> [!note] | ||
> See "TODO add link here" for context. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I assume you are already planning on updating this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, yeah I'm going to write something on the public docs and add the link here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
With Anders comment
Would it take long to have that link so we can we merge this and make it part of apps v0.44?
PR for public docs update: elastisys/welkin#1050 |
Warning
This is a public repository, ensure not to disclose:
What kind of PR is this?
Required: Mark one of the following that is applicable:
Optional: Mark one or more of the following that are applicable:
Important
Breaking changes should be marked
kind/admin-change
orkind/dev-change
depending on typeCritical security fixes should be marked with
kind/security
What does this PR do / why do we need this PR?
Adds a policy that can reject the use of pods without any controller/ownerReference (i.e. pods that does not belong to a deployment/daemonset/job/...). This is primarily to avoid situations where the cluster autoscaler cannot scale down a node because it will not evict pods with local storage.
Part of #2318
Information to reviewers
Checklist