Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for release v0.44.0 #2434

Open
wants to merge 13 commits into
base: release-0.44
Choose a base branch
from
Open

Conversation

lunkan93
Copy link
Contributor

@lunkan93 lunkan93 commented Feb 12, 2025

Warning

This is a public repository, ensure not to disclose:

  • personal data beyond what is necessary for interacting with this pull request, nor
  • business confidential information, such as customer names.

What kind of PR is this?

Required: Mark one of the following that is applicable:

  • kind/feature
  • kind/improvement
  • kind/deprecation
  • kind/documentation
  • kind/clean-up
  • kind/bug
  • kind/other

Optional: Mark one or more of the following that are applicable:

Important

Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

  • kind/admin-change
  • kind/dev-change
  • kind/security
  • [kind/adr](set-me)

What does this PR do / why do we need this PR?

...

  • Fixes #

Information to reviewers

Checklist

  • Proper commit message prefix on all commits
  • Change checks:
    • The change is transparent
    • The change is disruptive
    • The change requires no migration steps
    • The change requires migration steps
    • The change updates CRDs
    • The change updates the config and the schema
  • Documentation checks:
  • Metrics checks:
    • The metrics are still exposed and present in Grafana after the change
    • The metrics names didn't change (Grafana dashboards and Prometheus alerts required no updates)
    • The metrics names did change (Grafana dashboards and Prometheus alerts required an update)
  • Logs checks:
    • The logs do not show any errors after the change
  • PodSecurityPolicy checks:
    • Any changed Pod is covered by Kubernetes Pod Security Standards
    • Any changed Pod is covered by Gatekeeper Pod Security Policies
    • The change does not cause any Pods to be blocked by Pod Security Standards or Policies
  • NetworkPolicy checks:
    • Any changed Pod is covered by Network Policies
    • The change does not cause any dropped packets in the NetworkPolicy Dashboard
  • Audit checks:
    • The change does not cause any unnecessary Kubernetes audit events
    • The change requires changes to Kubernetes audit policy
  • Falco checks:
    • The change does not cause any alerts to be generated by Falco
  • Bug checks:
    • The bug fix is covered by regression tests

@lunkan93 lunkan93 marked this pull request as ready for review February 19, 2025 14:06
@lunkan93 lunkan93 requested review from a team as code owners February 19, 2025 14:06
Copy link
Contributor

@simonklb simonklb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize that the release process isn't clear on this but I think that if something as big as having to upgrade a component is found as a release blocker it should be made as a separate PR.

Otherwise the review process risks being compromised just to get the release out the door.

Honestly, I'd like to see us change our release process in a way where all fixes are made on main and backported to the release branch. @aarnq WDYT?

- [b69e4d9](https://github.com/elastisys/compliantkubernetes-apps/commit/b69e4d949811e9b75cd477fd0e22730871a8910a) - Upgrade OpenSearch and OpenSearch Dashboards to v2.18 [@lunkan93](https://github.com/lunkan93)
- [935889d](https://github.com/elastisys/compliantkubernetes-apps/commit/935889d4b049c079385b394908d1afde034e7b18) - Fix backups dashboard incorrect off-site state with syncDefaultBuckets [@lunkan93](https://github.com/lunkan93)
- [6a518ab](https://github.com/elastisys/compliantkubernetes-apps/commit/6a518abbd744cb1387a0c52a08d9e434c0642275) - Add label to cluster selector in Nginx dashboard [@lunkan93](https://github.com/lunkan93)
- [e57d026](https://github.com/elastisys/compliantkubernetes-apps/commit/e57d02682e899ca0b4d5957ee03b480ad69d3d2f) - Move kubeapi-metrics htpasswd from chart to config [@lunkan93](https://github.com/lunkan93)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that this is finally addressed! 🙌

changelog/0.44.md Outdated Show resolved Hide resolved
> **Application Developer Notice(s)**
> - Prometheus has been upgraded to [version 3.0](https://prometheus.io/blog/2024/11/14/prometheus-3-0/). This includes changes to the Prometheus UI. Prometheus V3 comes with some changes that may affect existing PromQL expressions in alerts or dashboards. Please have a look at the Prometheus V3 [migration guide](https://prometheus.io/docs/prometheus/3.0/migration/).
## Release highlights
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we maybe want to highlight more things for this release? E.g. addition of GPU operator chart

@lunkan93
Copy link
Contributor Author

I realize that the release process isn't clear on this but I think that if something as big as having to upgrade a component is found as a release blocker it should be made as a separate PR.

Otherwise the review process risks being compromised just to get the release out the door.

Honestly, I'd like to see us change our release process in a way where all fixes are made on main and backported to the release branch. @aarnq WDYT?

I do agree with what you're saying, the problem that prompted this was discussed with @aarnq and we decided that the best course of action would be to upgrade, as it was a relatively small one, and the bug it fixes had potential to be pretty bad.

Unfortunately @aarnq is away so he can't weigh in, and it is quite important that this release is finished this week. I agree that we should probably have a process in place for how we handle these types of outliers where an actual upgrade is needed.

Tagging some people to get more thoughts on this @viktor-f @OlleLarsson @davidumea @Xartos

@simonklb
Copy link
Contributor

I realize that the release process isn't clear on this but I think that if something as big as having to upgrade a component is found as a release blocker it should be made as a separate PR.
Otherwise the review process risks being compromised just to get the release out the door.
Honestly, I'd like to see us change our release process in a way where all fixes are made on main and backported to the release branch. @aarnq WDYT?

I do agree with what you're saying, the problem that prompted this was discussed with @aarnq and we decided that the best course of action would be to upgrade, as it was a relatively small one, and the bug it fixes had potential to be pretty bad.

Unfortunately @aarnq is away so he can't weigh in, and it is quite important that this release is finished this week. I agree that we should probably have a process in place for how we handle these types of outliers where an actual upgrade is needed.

Tagging some people to get more thoughts on this @viktor-f @OlleLarsson @davidumea @Xartos

If it has been cleared by @aarnq I'm fine with going ahead with this! Food for thought though. Releases should not feel rushed, especially if we allow fixes instead of backports.

@simonklb simonklb dismissed their stale review February 19, 2025 15:14

Dismissing so that I don't block if it gets approved before I have the time to review it.

@simonklb simonklb self-requested a review February 19, 2025 15:14
@davidumea
Copy link
Contributor

davidumea commented Feb 19, 2025

I realize that the release process isn't clear on this but I think that if something as big as having to upgrade a component is found as a release blocker it should be made as a separate PR.
Otherwise the review process risks being compromised just to get the release out the door.
Honestly, I'd like to see us change our release process in a way where all fixes are made on main and backported to the release branch. @aarnq WDYT?

I do agree with what you're saying, the problem that prompted this was discussed with @aarnq and we decided that the best course of action would be to upgrade, as it was a relatively small one, and the bug it fixes had potential to be pretty bad.
Unfortunately @aarnq is away so he can't weigh in, and it is quite important that this release is finished this week. I agree that we should probably have a process in place for how we handle these types of outliers where an actual upgrade is needed.
Tagging some people to get more thoughts on this @viktor-f @OlleLarsson @davidumea @Xartos

If it has been cleared by @aarnq I'm fine with going ahead with this! Food for thought though. Releases should not feel rushed, especially if we allow fixes instead of backports.

I think that fixes being done on main and backported to the release is better, to get it properly reviewed. Great suggestion 👍

I think it's fine to do the upgrade here in this case since we don't have any process in place for doing it differently.

Releases should not feel rushed

Unfortunately there were some pressure from other parties for a feature in this release to be available next week, so this time we were a bit rushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants