-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog for release v0.44.0 #2434
base: release-0.44
Are you sure you want to change the base?
Conversation
c133e9d
to
7147e58
Compare
7147e58
to
fe0ec2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize that the release process isn't clear on this but I think that if something as big as having to upgrade a component is found as a release blocker it should be made as a separate PR.
Otherwise the review process risks being compromised just to get the release out the door.
Honestly, I'd like to see us change our release process in a way where all fixes are made on main and backported to the release branch. @aarnq WDYT?
- [b69e4d9](https://github.com/elastisys/compliantkubernetes-apps/commit/b69e4d949811e9b75cd477fd0e22730871a8910a) - Upgrade OpenSearch and OpenSearch Dashboards to v2.18 [@lunkan93](https://github.com/lunkan93) | ||
- [935889d](https://github.com/elastisys/compliantkubernetes-apps/commit/935889d4b049c079385b394908d1afde034e7b18) - Fix backups dashboard incorrect off-site state with syncDefaultBuckets [@lunkan93](https://github.com/lunkan93) | ||
- [6a518ab](https://github.com/elastisys/compliantkubernetes-apps/commit/6a518abbd744cb1387a0c52a08d9e434c0642275) - Add label to cluster selector in Nginx dashboard [@lunkan93](https://github.com/lunkan93) | ||
- [e57d026](https://github.com/elastisys/compliantkubernetes-apps/commit/e57d02682e899ca0b4d5957ee03b480ad69d3d2f) - Move kubeapi-metrics htpasswd from chart to config [@lunkan93](https://github.com/lunkan93) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that this is finally addressed! 🙌
> **Application Developer Notice(s)** | ||
> - Prometheus has been upgraded to [version 3.0](https://prometheus.io/blog/2024/11/14/prometheus-3-0/). This includes changes to the Prometheus UI. Prometheus V3 comes with some changes that may affect existing PromQL expressions in alerts or dashboards. Please have a look at the Prometheus V3 [migration guide](https://prometheus.io/docs/prometheus/3.0/migration/). | ||
## Release highlights |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we maybe want to highlight more things for this release? E.g. addition of GPU operator chart
I do agree with what you're saying, the problem that prompted this was discussed with @aarnq and we decided that the best course of action would be to upgrade, as it was a relatively small one, and the bug it fixes had potential to be pretty bad. Unfortunately @aarnq is away so he can't weigh in, and it is quite important that this release is finished this week. I agree that we should probably have a process in place for how we handle these types of outliers where an actual upgrade is needed. Tagging some people to get more thoughts on this @viktor-f @OlleLarsson @davidumea @Xartos |
If it has been cleared by @aarnq I'm fine with going ahead with this! Food for thought though. Releases should not feel rushed, especially if we allow fixes instead of backports. |
Dismissing so that I don't block if it gets approved before I have the time to review it.
I think that fixes being done on main and backported to the release is better, to get it properly reviewed. Great suggestion 👍 I think it's fine to do the upgrade here in this case since we don't have any process in place for doing it differently.
Unfortunately there were some pressure from other parties for a feature in this release to be available next week, so this time we were a bit rushed. |
Warning
This is a public repository, ensure not to disclose:
What kind of PR is this?
Required: Mark one of the following that is applicable:
Optional: Mark one or more of the following that are applicable:
Important
Breaking changes should be marked
kind/admin-change
orkind/dev-change
depending on typeCritical security fixes should be marked with
kind/security
What does this PR do / why do we need this PR?
...
Information to reviewers
Checklist