fix: Fix electron-updater error handling when spawning a process asyn…

…chronously (#7524)
electron-userland · Apr 6, 2023 · 1a13480 · 1a13480
1 parent 2a8d7e6
commit 1a13480
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/tricky-flies-bow.md b/.changeset/tricky-flies-bow.md
@@ -0,0 +1,5 @@
+---
+"electron-updater": patch
+---
+
+Fixed error handling when launching updater (fixes NSIS updates when isAdminRightsRequired is incorrectly set to false)
diff --git a/packages/electron-updater/src/BaseUpdater.ts b/packages/electron-updater/src/BaseUpdater.ts
@@ -144,7 +144,7 @@ export abstract class BaseUpdater extends AppUpdater {
           reject(error)
         })
         p.unref()
-        if (process.pid !== undefined) {
+        if (p.pid !== undefined) {
           resolve(true)
         }
       } catch (error) {