fix: custom publisher extension check and throw error if not found (#…

…8926)
electron-userland · Mar 3, 2025 · 3caab3c · 3caab3c
1 parent fb3b15f
commit 3caab3c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/eight-mails-bathe.md b/.changeset/eight-mails-bathe.md
@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+fix: fix custom publisher check and throw error if not found
diff --git a/packages/app-builder-lib/src/publish/PublishManager.ts b/packages/app-builder-lib/src/publish/PublishManager.ts
@@ -354,7 +354,7 @@ async function requireProviderClass(provider: string, packager: Packager): Promi
       return BitbucketPublisher
 
     default: {
-      const extensions = [".mjs", ".js", ".cjs"]
+      const extensions = ["mjs", "js", "cjs"]
       const template = `electron-publisher-${provider}`
       const name = (ext: string) => `${template}.${ext}`
 
@@ -365,7 +365,8 @@ async function requireProviderClass(provider: string, packager: Packager): Promi
           return module.default || module
         }
       }
-      log.warn({ path: log.filePath(packager.buildResourcesDir), template, extensionsChecked: extensions }, "unable to find publish provider in build resources")
+      log.error({ path: log.filePath(packager.buildResourcesDir), template, extensionsChecked: extensions }, "unable to find publish provider in build resources")
+      throw new InvalidConfigurationError(`Cannot find module for publisher "${provider}" with any extension: ${extensions.join(", ")}`)
     }
   }
 }