fix(AppImage): fix AppImage build regression if max compression used

Close #2664
electron-userland · Mar 6, 2018 · 5081536 · 5081536
1 parent 3f6f5b6
commit 5081536
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 24 deletions.
diff --git a/package.json b/package.json
@@ -29,7 +29,7 @@
   "////": "All typings are added into root `package.json` to avoid duplication errors in the IDE compiler (several `node.d.ts` files).",
   "dependencies": {
     "7zip-bin": "~3.1.0",
-    "app-builder-bin": "1.7.0",
+    "app-builder-bin": "1.7.1",
     "archiver": "^2.1.1",
     "async-exit-hook": "^2.0.1",
     "aws-sdk": "^2.205.0",
@@ -73,7 +73,7 @@
     "@types/ejs": "^2.5.0",
     "@types/electron-is-dev": "^0.3.0",
     "@types/ini": "^1.3.29",
-    "@types/jest": "^22.1.4",
+    "@types/jest": "^22.2.0",
     "@types/js-yaml": "^3.10.1",
     "@types/lodash.isequal": "^4.5.2",
     "@types/node-emoji": "^1.8.0",

diff --git a/packages/builder-util/package.json b/packages/builder-util/package.json
@@ -11,7 +11,7 @@
     "out"
   ],
   "dependencies": {
-    "app-builder-bin": "1.7.0",
+    "app-builder-bin": "1.7.1",
     "temp-file": "^3.1.1",
     "fs-extra-p": "^4.5.2",
     "is-ci": "^1.1.0",

diff --git a/packages/electron-builder-lib/package.json b/packages/electron-builder-lib/package.json
@@ -42,7 +42,7 @@
   "homepage": "https://github.com/electron-userland/electron-builder",
   "dependencies": {
     "7zip-bin": "~3.1.0",
-    "app-builder-bin": "1.7.0",
+    "app-builder-bin": "1.7.1",
     "async-exit-hook": "^2.0.1",
     "bluebird-lst": "^1.0.5",
     "chromium-pickle-js": "^0.2.0",

diff --git a/test/out/linux/__snapshots__/linuxPackagerTest.js.snap b/test/out/linux/__snapshots__/linuxPackagerTest.js.snap
@@ -79,7 +79,7 @@ Object {
 }
 `;
 
-exports[`AppImage arm 1`] = `
+exports[`AppImage arm, max compression 1`] = `
 Object {
   "linux": Array [
     Object {

diff --git a/test/src/linux/linuxPackagerTest.ts b/test/src/linux/linuxPackagerTest.ts
@@ -27,10 +27,11 @@ test.ifAll.ifNotWindows.ifNotCiMac("AppImage ia32", app({
   },
 }))
 
-test.ifAll.ifNotWindows.ifNotCiMac("AppImage arm", app({
+test.ifAll.ifNotWindows.ifNotCiMac("AppImage arm, max compression", app({
   targets: Platform.LINUX.createTarget("Appimage", Arch.armv7l),
   config: {
     publish: null,
+    compression: "maximum",
   },
 }))
 

diff --git a/yarn.lock b/yarn.lock
@@ -112,9 +112,9 @@
   version "1.3.29"
   resolved "https://registry.yarnpkg.com/@types/ini/-/ini-1.3.29.tgz#1325e981e047d40d13ce0359b821475b97741d2f"
 
-"@types/jest@^22.1.4":
-  version "22.1.4"
-  resolved "https://registry.yarnpkg.com/@types/jest/-/jest-22.1.4.tgz#5c0c06a9bb495c67e0a78002a952f151e2ae58a1"
+"@types/jest@^22.2.0":
+  version "22.2.0"
+  resolved "https://registry.yarnpkg.com/@types/jest/-/jest-22.2.0.tgz#55ce83139f7ad1b48b414c3927746614c6963c0f"
 
 "@types/js-yaml@^3.10.1":
   version "3.10.1"
@@ -275,25 +275,25 @@ anymatch@^1.3.0:
     micromatch "^2.1.5"
     normalize-path "^2.0.0"
 
-[email protected].0:
-  version "1.7.0"
-  resolved "https://registry.yarnpkg.com/app-builder-bin-linux/-/app-builder-bin-linux-1.7.0.tgz#83894c51e224382a7268997cc8af1283c1be21e3"
+[email protected].1:
+  version "1.7.1"
+  resolved "https://registry.yarnpkg.com/app-builder-bin-linux/-/app-builder-bin-linux-1.7.1.tgz#925967add77c13d387e3fe88359a4b4dce82c525"
 
-[email protected].0:
-  version "1.7.0"
-  resolved "https://registry.yarnpkg.com/app-builder-bin-mac/-/app-builder-bin-mac-1.7.0.tgz#067a91d612fd3c2b687a097343ec4bb5f42c2e5f"
+[email protected].1:
+  version "1.7.1"
+  resolved "https://registry.yarnpkg.com/app-builder-bin-mac/-/app-builder-bin-mac-1.7.1.tgz#e5c2b49be82473a737e000cfccfc65a68f9cc62d"
 
-[email protected].0:
-  version "1.7.0"
-  resolved "https://registry.yarnpkg.com/app-builder-bin-win/-/app-builder-bin-win-1.7.0.tgz#caf81af88c5506717e4015880981b4ed3508414f"
+[email protected].1:
+  version "1.7.1"
+  resolved "https://registry.yarnpkg.com/app-builder-bin-win/-/app-builder-bin-win-1.7.1.tgz#e1ba3d6d645896552b28e4dd05525b39561b9b88"
 
-[email protected].0:
-  version "1.7.0"
-  resolved "https://registry.yarnpkg.com/app-builder-bin/-/app-builder-bin-1.7.0.tgz#cb83e469d511f3516af7bca5288b692604bbd5c1"
+[email protected].1:
+  version "1.7.1"
+  resolved "https://registry.yarnpkg.com/app-builder-bin/-/app-builder-bin-1.7.1.tgz#c2540eb8b164c91c30bc8cf3f16b5c181f3f5c31"
   optionalDependencies:
-    app-builder-bin-linux "1.7.0"
-    app-builder-bin-mac "1.7.0"
-    app-builder-bin-win "1.7.0"
+    app-builder-bin-linux "1.7.1"
+    app-builder-bin-mac "1.7.1"
+    app-builder-bin-win "1.7.1"
 
 append-transform@^0.4.0:
   version "0.4.0"