Skip to content

Commit

Permalink
fix(mac): clean macOsVersion before gte comparison (#1733)
Browse files Browse the repository at this point in the history
* Clean macOsVersion before gte comparison

Since 10.12 is a possible Sierra version, clean before doing comparison to avoid "Invalid Version" error from SemVer
naderhen authored and develar committed Jun 22, 2017
1 parent 0a98870 commit 7ff95ca
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions packages/electron-builder/src/util/macosVersion.ts
Original file line number Diff line number Diff line change
@@ -17,10 +17,11 @@ function clean(version: string) {

/** @internal */
export async function isOsVersionGreaterThanOrEqualTo(input: string) {
return semver.gte(await macOsVersion.value, clean(input))
const version = await macOsVersion.value
return semver.gte(clean(version), clean(input))
}

/** @internal */
export async function isMacOsSierra() {
return process.platform === "darwin" && await isOsVersionGreaterThanOrEqualTo("10.12")
}
return process.platform === "darwin" && await isOsVersionGreaterThanOrEqualTo("10.12.0")
}

0 comments on commit 7ff95ca

Please sign in to comment.