Skip to content

Commit

Permalink
fix: afterPack Usage in Build Config
Browse files Browse the repository at this point in the history
Close #2255
  • Loading branch information
develar committed Nov 2, 2017
1 parent b20166a commit 9b21b09
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 20 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
"convert-source-map": "^1.5.0",
"decompress-zip": "^0.3.0",
"depcheck": "^0.6.8",
"develar-typescript-json-schema": "0.17.0",
"develar-typescript-json-schema": "0.19.0",
"electron-builder-tslint-config": "^1.1.0",
"env-paths": "^1.0.0",
"finalhandler": "^1.1.0",
Expand All @@ -107,7 +107,7 @@
"ts-babel": "^4.1.7",
"ts-jsdoc": "^2.0.6",
"tslint": "^5.8.0",
"typescript": "^2.6.0-rc",
"typescript": "2.6.0-rc",
"v8-compile-cache": "^1.1.0",
"whitespace": "^2.1.0",
"worker-farm": "^1.5.1"
Expand Down
4 changes: 2 additions & 2 deletions packages/electron-builder/src/configuration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,11 @@ export interface Configuration extends PlatformSpecificBuildOptions {
/**
* The function (or path to file or module id) to be run after pack (but before pack into distributable format and sign).
*/
readonly afterPack?: (context: AfterPackContext) => Promise<any> | null
readonly afterPack?: ((context: AfterPackContext) => Promise<any>) | string | null
/**
* The function (or path to file or module id) to be run before dependencies are installed or rebuilt. Works when `npmRebuild` is set to `true`. Resolving to `false` will skip dependencies install or rebuild.
*/
readonly beforeBuild?: (context: BeforeBuildContext) => Promise<any> | null
readonly beforeBuild?: ((context: BeforeBuildContext) => Promise<any>) | string| null
}

export interface AfterPackContext {
Expand Down
2 changes: 1 addition & 1 deletion packages/electron-publisher-s3/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
],
"dependencies": {
"fs-extra-p": "^4.4.4",
"aws-sdk": "^2.141.0",
"aws-sdk": "^2.142.0",
"mime": "^2.0.3",
"electron-publish": "~0.0.0-semantic-release",
"builder-util": "^0.0.0-semantic-release",
Expand Down
37 changes: 22 additions & 15 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -440,8 +440,8 @@ asynckit@^0.4.0:
resolved "https://registry.yarnpkg.com/asynckit/-/asynckit-0.4.0.tgz#c79ed97f7f34cb8f2ba1bc9790bcc366474b4b79"

aws-sdk@^2.141.0:
version "2.141.0"
resolved "https://registry.yarnpkg.com/aws-sdk/-/aws-sdk-2.141.0.tgz#3d96a5970fd9f540ceabcc1d4baeb33b71583aa7"
version "2.142.0"
resolved "https://registry.yarnpkg.com/aws-sdk/-/aws-sdk-2.142.0.tgz#efdf69d2be3132aa51d4e7abb2c28fe42771e3ec"
dependencies:
buffer "4.9.1"
crypto-browserify "1.0.9"
Expand Down Expand Up @@ -1373,21 +1373,25 @@ detect-indent@^4.0.0:
dependencies:
repeating "^2.0.0"

detect-libc@^1.0.2:
version "1.0.2"
resolved "https://registry.yarnpkg.com/detect-libc/-/detect-libc-1.0.2.tgz#71ad5d204bf17a6a6ca8f450c61454066ef461e1"

detect-newline@^1.0.3:
version "1.0.3"
resolved "https://registry.yarnpkg.com/detect-newline/-/detect-newline-1.0.3.tgz#e97b1003877d70c09af1af35bfadff168de4920d"
dependencies:
get-stdin "^4.0.1"
minimist "^1.1.0"

develar-typescript-json-schema@0.17.0:
version "0.17.0"
resolved "https://registry.yarnpkg.com/develar-typescript-json-schema/-/develar-typescript-json-schema-0.17.0.tgz#f32a165e45b73abe0f4fb3b79603e8fc61e76f5d"
develar-typescript-json-schema@0.19.0:
version "0.19.0"
resolved "https://registry.yarnpkg.com/develar-typescript-json-schema/-/develar-typescript-json-schema-0.19.0.tgz#250f4a56d2f3fcc3715c684ec103f16e449a00b2"
dependencies:
glob "~7.1.2"
json-stable-stringify "^1.0.1"
typescript "~2.4.1"
yargs "^8.0.2"
typescript "~2.5.3"
yargs "^10.0.3"

dezalgo@^1.0.0:
version "1.0.3"
Expand Down Expand Up @@ -3393,8 +3397,10 @@ next-tick@~0.2.2:
resolved "https://registry.yarnpkg.com/next-tick/-/next-tick-0.2.2.tgz#75da4a927ee5887e39065880065b7336413b310d"

node-abi@^2.1.1:
version "2.1.1"
resolved "https://registry.yarnpkg.com/node-abi/-/node-abi-2.1.1.tgz#c9cda256ec8aa99bcab2f6446db38af143338b2a"
version "2.1.2"
resolved "https://registry.yarnpkg.com/node-abi/-/node-abi-2.1.2.tgz#4da6caceb6685fcd31e7dd1994ef6bb7d0a9c0b2"
dependencies:
semver "^5.4.1"

node-emoji@^1.8.1:
version "1.8.1"
Expand All @@ -3416,9 +3422,10 @@ node-notifier@^5.0.2:
which "^1.2.12"

node-pre-gyp@^0.6.36:
version "0.6.38"
resolved "https://registry.yarnpkg.com/node-pre-gyp/-/node-pre-gyp-0.6.38.tgz#e92a20f83416415bb4086f6d1fb78b3da73d113d"
version "0.6.39"
resolved "https://registry.yarnpkg.com/node-pre-gyp/-/node-pre-gyp-0.6.39.tgz#c00e96860b23c0e1420ac7befc5044e1d78d8649"
dependencies:
detect-libc "^1.0.2"
hawk "3.1.3"
mkdirp "^0.5.1"
nopt "^4.0.1"
Expand Down Expand Up @@ -4845,13 +4852,13 @@ type-is@~1.6.10:
media-typer "0.3.0"
mime-types "~2.1.15"

typescript@^2.6.0-rc:
[email protected]:
version "2.6.0-rc"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-2.6.0-rc.tgz#6a8022e2dd3e7033f2dcf187cff7925ea3c8ac25"

typescript@~2.4.1:
version "2.4.2"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-2.4.2.tgz#f8395f85d459276067c988aa41837a8f82870844"
typescript@~2.5.3:
version "2.5.3"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-2.5.3.tgz#df3dcdc38f3beb800d4bc322646b04a3f6ca7f0d"

typical@^2.4.2, typical@^2.6.0, typical@^2.6.1:
version "2.6.1"
Expand Down

0 comments on commit 9b21b09

Please sign in to comment.