Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[electron-updater] response from Generic Provider getLatestVersion becomes [ 'Object object' ] #1853

Closed
vuamitom opened this issue Jul 24, 2017 · 5 comments
Labels

Comments

@vuamitom
Copy link

  • Version:
    electron-builder 19.16.0

electron-updater 2.7.1

  • Target: Windows 64bit

Look like something wrong with the call to HttpExecutor in Generic Provider.

result = safeLoad(await this.executor.request<string>(options))

result objects becomes ['Object object'] instead of the proper json that has been returned.

Reverting to electron-updater 1.15.0, where HttpExecutor is not used, fixes this issue.

@develar
Copy link
Member

develar commented Jul 25, 2017

Is your server returns correct JSON mime-types?

@develar develar added the bug label Jul 25, 2017
@develar
Copy link
Member

develar commented Jul 25, 2017

Ok, code will be simplified to avoid such errors.

develar added a commit to develar/electron-builder that referenced this issue Jul 25, 2017
@vuamitom
Copy link
Author

Is your server returns correct JSON mime-types?

It's returning response with header: 'Content-Type': 'application/json'

@develar
Copy link
Member

develar commented Jul 25, 2017

Please try new version.

@vuamitom
Copy link
Author

Thank you, that was a quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants