Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-builder loses *.h file with and without asar active #1971

Closed
AlexisLapeze opened this issue Aug 21, 2017 · 6 comments
Closed

electron-builder loses *.h file with and without asar active #1971

AlexisLapeze opened this issue Aug 21, 2017 · 6 comments
Labels

Comments

@AlexisLapeze
Copy link

AlexisLapeze commented Aug 21, 2017

  • Version: 1.7.6
  • Target: Linux x64 and Win x64

In my application, I'm using some "*.h" file. When I run npm run dist script ("dist": "build") all of my "*.h" files disappear on the unpack folder (and the executable is unusable). It's not an asar problem, I try asarUnpack and "asar" : "false" for unpack my folder with my "*.h" and I have the same result.
Every "*.h" file in every subfolder is deleted, no exception...

At the beginning I suspected asar, but I installed it globally with npm on my computer and it's work perfectly : my "*.h" files are not lost. (asar pack myFolder myFolder.asar and asar e myFolder.asar testFolder)

@develar
Copy link
Member

develar commented Aug 21, 2017

Yes .h files are excluded by default. Do you mean that these files are part of your app, not from node_modules?

@AlexisLapeze
Copy link
Author

Yes they are part of my app. Is there a way to include them ?

@develar
Copy link
Member

develar commented Aug 21, 2017

@Alexisdu31 Fixed in the 19.24.2

.h files must be filtered out only from node_modules, not from app.

@AlexisLapeze
Copy link
Author

AlexisLapeze commented Aug 21, 2017

Thank you verry much @develar, it's work perfectly !

npm update for update electron-builder to 19.24.2 !

I just found i have .o file too in my project :/ To tell you everything i embedded an arduino package on my app (i have no other options) and arduino package need .o file in avr to compile my scketch.

Its possible to delete o file in fileMatcher.ts or not ?

Alexis

develar added a commit that referenced this issue Aug 21, 2017
Quite uncommon for apps to have o files, so, we just should include it — if someone need to exclude it, well, just ignore. For node_modules should be removed as before.

Fix #1971
@develar
Copy link
Member

develar commented Aug 21, 2017

Quite uncommon for apps to have o files, so, we just should include it — if someone need to exclude it, well, just ignore. For node_modules should be removed as before.

19.24.3

npm update

Will not work because these releases are not latest, tag next is used for pre-releases.

@AlexisLapeze
Copy link
Author

Thank you very much @develar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants