Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delta updates for NSIS target (not only nsis-web target) #2217

Closed
SteveJay7 opened this issue Oct 22, 2017 · 8 comments
Closed

Delta updates for NSIS target (not only nsis-web target) #2217

SteveJay7 opened this issue Oct 22, 2017 · 8 comments

Comments

@SteveJay7
Copy link

I am using electron-builder 19.37.2

I would like to have delta updates for my nsis (win x64) installer, so I added "differentialPackage": true to my nsis options.

But still, only the full version is being created and published.
Although it seems that adding this option triggered some different code because the size of the installers exe file changed from 60MB to 63MB (without any code changes).

I would appreciate any help in finding the issue why no delta file is being created.

Thanks!

@develar
Copy link
Member

develar commented Oct 22, 2017

Supported only for nsis-web target for now.

@develar develar changed the title problem with delta updates for nsis Delta updates for NSIS target (not only nsis-web target) Oct 22, 2017
@SteveJay7
Copy link
Author

SteveJay7 commented Oct 22, 2017

thanks for the quick response.

I changed target to nsis-web. now the web-installer adn the 7z files are created, but the 7z files are still all 64MB.

is there something wrong in my config?

...
"asar": true,
"win": {
"icon": "build/icons/icon.ico",
"target": "nsis-web"
},
"nsisWeb": {
"installerIcon": "build/icons/icon.ico",
"differentialPackage": true,
"artifactName": "${productName}Setup${version}.${ext}"
},
...

@BethanyBerkowitz
Copy link

@develar my team is also quite interested in differential updates for the nsis target! I'll be making a donation shortly.

@develar
Copy link
Member

develar commented Nov 21, 2017

@BethanyBerkowitz Status update — I still cannot finish one feature, but work on this issue will be started this week. Sorry for delay.

@BethanyBerkowitz
Copy link

@develar Will I be getting an nsis Christmas present or coal in my stocking? 🎄 🎅

@jan-j
Copy link

jan-j commented Jan 9, 2018

@develar Is this feature still work in progress? I've tried it myself with latest electron-builder and electron-updater, but it seems like it only works with NSIS_DIFFERENTIAL_UPDATE env variable set to true and then it still misses *.blockMap.json file which is not generated (at least without debug env var).

BTW thank you for building great Electron tools

develar added a commit to develar/electron-builder that referenced this issue Jan 24, 2018
@Dorkside
Copy link

Dorkside commented Mar 5, 2018

Any update on this feature? Nsis-web target is OK for now, but doesn't emit the correct progress events while downloading.
Progress works fine with nsis target, but doesn't do differential, so isn't optimal.

@olleweb
Copy link

olleweb commented Sep 8, 2021

@develar Does delta updates work for NSIS target now? I have set differentialPackage to true for nsis but I still get "Cannot download differentially, fallback to full download". It works as expected when using the nsis-web installer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants