Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mac updates breaking change #2276

Closed
nkt opened this issue Nov 6, 2017 · 7 comments
Closed

Mac updates breaking change #2276

nkt opened this issue Nov 6, 2017 · 7 comments
Labels
bug deployment mac

Comments

@nkt
Copy link

nkt commented Nov 6, 2017

[email protected] doesn't upload to S3 latest-mac.yml file, even if electronUpdaterCompatibility: '>=1.0.0' added explicitly.
@develar
Copy link
Member

develar commented Nov 7, 2017

S3 Publisher Version?

@nkt
Copy link
Author

nkt commented Nov 7, 2017

19.42.0

@develar
Copy link
Member

develar commented Nov 7, 2017

Please use latest 19.45.0

@nkt
Copy link
Author

nkt commented Nov 7, 2017

ah, sorry. 19.45.0

@nkt
Copy link
Author

nkt commented Nov 7, 2017

@develar as I can see in code, this issue doesn't related to s3 publisher, since publisher just publishes files, which electron-builder gives.

@develar
Copy link
Member

develar commented Nov 7, 2017

Working on, very strange that our test suite doesn't catch it.

develar added a commit to develar/electron-builder that referenced this issue Nov 7, 2017
@develar
fix(deployment): Mac updates breaking change
4649016 
Close electron-userland#2276
@develar develar closed this as completed in f664497 Nov 7, 2017
@nkt
Copy link
Author

nkt commented Nov 7, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug deployment mac
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@develar @nkt