Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not strip "bugs" field from package.json #2606

Closed
mcous opened this issue Feb 19, 2018 · 2 comments · May be fixed by qcif/data-curator#563
Closed

do not strip "bugs" field from package.json #2606

mcous opened this issue Feb 19, 2018 · 2 comments · May be fixed by qcif/data-curator#563
Labels

Comments

@mcous
Copy link

mcous commented Feb 19, 2018

  • Version: Applies to >= v19.49.3
  • Target: macOS (zip), Windows (NSIS), Linux (deb)

First off, thanks for all your hard work on this project!

I would like to include a "Report an Issue" link in my app. For consistency, I would like to drive that link with the bugs.url field in my application's package.json. However, 4dc71d7 introduced a change in packages/electron-builder-lib/src/fileTransformer.ts so that the bugs field gets stripped from package.json.

This ticket is to request that bugs not be removed, or if its removal is important for some use-cases, an option similar to removePackageScripts and extraMetadata to whitelist certain fields from removal. If one of these changes seem useful, I'm happy to open a PR!

@develar develar changed the title Request: do not strip "bugs" field from package.json do not strip "bugs" field from package.json Feb 20, 2018
@develar
Copy link
Member

develar commented Feb 20, 2018

To avoid such issues, bugs should be removed only from dependencies, not from app package.json. Thanks for clear error report.

@develar develar added the bug label Feb 20, 2018
develar added a commit to develar/electron-builder that referenced this issue Feb 20, 2018
@mcous
Copy link
Author

mcous commented Feb 20, 2018

Thank you very much for the quick resolution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants