Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error publishing to github when building on travis #261

Closed
jbleuzen opened this issue Mar 21, 2016 · 7 comments · May be fixed by qcif/data-curator#563
Closed

Error publishing to github when building on travis #261

jbleuzen opened this issue Mar 21, 2016 · 7 comments · May be fixed by qcif/data-curator#563
Assignees
Labels

Comments

@jbleuzen
Copy link

Hi,
I have error on my Travis instance when building my app : GitHub Personal Access Token is not specified. The fact is I don't want to publish to github so I want to disable this publish thing.

I've added this in my package.json (the developper one) :

"build": {
"publish": "never"
...
}

But when I read the docs, I see "But please consider to use automatic rules and don't specify publish explicitly". So, is the "publish" attribute used or not ???

@jbleuzen jbleuzen changed the title Publishing to github Error publishing to githubwhen building on travis Mar 21, 2016
@jbleuzen jbleuzen changed the title Error publishing to githubwhen building on travis Error publishing to github when building on travis Mar 21, 2016
@develar
Copy link
Member

develar commented Mar 21, 2016

Please provide full stack trace of error. Must be no error if you don't use script named release.

@develar develar added the bug label Mar 21, 2016
@develar develar self-assigned this Mar 21, 2016
@jbleuzen
Copy link
Author

I don't use npm release but npm run dist, here is the output i have as "raw log" in Travis :

Tag v0.1.0 is defined, so artifacts will be published
Installing app dependencies for arch x64 to /Users/travis/build/Product/web-app-desktop/app
Packaging app for platform darwin x64 using electron v0.36.8
App is not signed: CSC_LINK or CSC_NAME are not specified
Creating DMG
Creating ZIP for Squirrel.Mac
Unhandled rejection Error: GitHub Personal Access Token is not specified
    at new GitHubPublisher (/Users/travis/build/Product/web-app-desktop/node_modules/electron-builder/src/gitHubPublisher.ts:36:13)
    at /Users/travis/build/Product/web-app-desktop/node_modules/electron-builder/src/builder.ts:23:12
    at [object Generator].next (native)
From previous event:
    at tsAwaiter (/Users/travis/build/Product/web-app-desktop/node_modules/electron-builder/src/awaiter.ts:10:51)
    at createPublisher (/Users/travis/build/Product/web-app-desktop/node_modules/electron-builder/src/builder.ts:12:146)
    at EventEmitter.<anonymous> (/Users/travis/build/Product/web-app-desktop/node_modules/electron-builder/src/builder.ts:81:49)
    at emitTwo (events.js:100:13)
    at EventEmitter.emit (events.js:185:7)
    at MacPackager.dispatchArtifactCreated (/Users/travis/build/Product/web-app-desktop/node_modules/electron-builder/src/platformPackager.ts:84:28)
    at /Users/travis/build/Product/web-app-desktop/node_modules/electron-builder/src/macPackager.ts:89:49
From previous event:
    at MacPackager.packageInDistributableFormat (/Users/travis/build/Product/web-app-desktop/node_modules/electron-builder/src/macPackager.ts:89:10)
    at Packager.<anonymous> (/Users/travis/build/Product/web-app-desktop/node_modules/electron-builder/src/packager.ts:79:33)
    at [object Generator].next (native)
    at processImmediate [as _immediateCallback] (timers.js:516:17)
From previous event:
    at tsAwaiter (/Users/travis/build/Product/web-app-desktop/node_modules/electron-builder/src/awaiter.ts:10:51)
    at Object.build (/Users/travis/build/Product/web-app-desktop/node_modules/electron-builder/src/builder.ts:30:55)
    at Object.<anonymous> (/Users/travis/build/Product/web-app-desktop/node_modules/electron-builder/src/build-cli.ts:41:2)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Function.Module.runMain (module.js:447:10)
    at startup (node.js:142:18)
    at node.js:939:3

Forgot to mention that I have this error twice in my log.

@jbleuzen
Copy link
Author

I forgot to mention that even when I set the argument 'publish' to 'never' with npm run dist -p never, I also get the error...

And I see that the params is well "understand" as I get this output :

> build "never"

@jbleuzen
Copy link
Author

It looks like no body have input to give me for this...
I looked the source and don't see a reason why the github publisher is running.

Maybe someone can help me reproduce the Travis setup so that I can edit code on my machine to fix this ?

@develar
Copy link
Member

develar commented Mar 25, 2016

@jbleuzen I returned from vacation and there were another issues to fix (remember, I work on project in my spare time by morning :)). Now I am going to investigate it. You can expect fix/solution today.

@jbleuzen
Copy link
Author

@develar didn't mean to be too pressing. Sorry about that and I hoped your vacation were fun :p

I was also offering help if I can replicate travis env so I can make some printf debug 😄
I looked at the code and don't understand why I get that message on travis only.

develar added a commit to develar/electron-builder that referenced this issue Mar 25, 2016

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mjcarroll Michael Carroll
@jbleuzen
Copy link
Author

Thanks @develar it's working !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants