Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is there a releaseDate? #2727

Closed
mkarp opened this issue Mar 21, 2018 · 2 comments
Closed

Why is there a releaseDate? #2727

mkarp opened this issue Mar 21, 2018 · 2 comments
Labels

Comments

@mkarp
Copy link

mkarp commented Mar 21, 2018

  • Versions:
"electron-builder": "20.5.1",
"electron-packager": "^11.1.0",
"electron-publisher-s3": "^20.5.0",
  • Target: macOS

When publishing a build with a command:

electron-builder --publish always -c.releaseInfo.releaseDate="2018-03-21T00:00:00.000Z"

the generated electron-builder.yaml contains the specified releaseDate, however in the generated latest-mac.yml the releaseDate is different. I assume it's the current timestamp, according to:

const releaseDate = new Date().toISOString()

Is this a bug or the releaseDate configuration option has a different intent?

Thank you!

@develar develar added the bug label Mar 27, 2018
@develar
Copy link
Member

develar commented Mar 27, 2018

Now releaseDate is not set if already set by user.

develar added a commit to develar/electron-builder that referenced this issue Mar 27, 2018
@mkarp
Copy link
Author

mkarp commented Mar 27, 2018

@develar Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants