Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows NSIS builds fail with MAXBUFFER error for very large archives #3704

Closed
dpgraham opened this issue Feb 21, 2019 · 1 comment
Closed

Comments

@dpgraham
Copy link
Contributor

Version: 20.38.5
Target: Windows NSIS

Attempts to build Windows NSIS with command build --win are failing with ERR_CHILD_PROCESS_STDIO_MAXBUFFER error.

Logs: https://gist.github.com/dpgraham/17e9758c29269d166bf8e5f9994b9e57

  • The problem is that 7zip logs the contents of the archive, and our archive is HUGE, which causes the ERR_CHILD_PROCESS_STDIO_MAXBUFFER error

  • I was able to fix it locally by changing the hardcoded maxBuffer from 10 * 1024 * 1024 to 1000 * 1024 * 1024 at this line

  • I suspect that the problem is happening in NsisTarget.ts where it's calling exec <7zipBinary> -l <.7z>. If the logs were suppressed on this line, that would probably fix the problem too.

Possible fixes are

  1. Bump up the maxBuffer size
  2. Suppress logging for call to the 7zip binary
  3. See if there's a flag to add to the call to the 7zip binary that prevents it from logging archive contents
  4. Make maxBuffer size configurable
dpgraham added a commit to dpgraham/electron-builder that referenced this issue Mar 8, 2019
@dpgraham
Copy link
Contributor Author

Here's an example of it happening: https://dev.azure.com/AppiumCI/Appium%20CI/_build/results?buildId=1237

develar pushed a commit that referenced this issue Apr 1, 2019
@develar develar closed this as completed Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants