Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: The pkg interface adds the must-close attribute #4380

Closed
BlackHole1 opened this issue Nov 1, 2019 · 3 comments
Closed

[feat]: The pkg interface adds the must-close attribute #4380

BlackHole1 opened this issue Nov 1, 2019 · 3 comments
Labels

Comments

@BlackHole1
Copy link
Contributor

  • Version: 22.1.0

  • Target: pkg

currently, some of the interfaces are provided when packaging the pkg application, but not all.

In the Apple developer documentation, there is a must-close attribute. I think this property is very necessary to join in.

Apple's introduction to must-close:

Identifies applications that must be closed before the package is installed.
Applications are considered only if the package that contains this element has been selected for installation.

Because the current electron-builder does not provide this property, it will not exit some apps that must be quit when installing pkg. You must use postinstall or preinstall to force the process to be killed. This is a very bad user check.

@BlackHole1
Copy link
Contributor Author

I added the relevant PR: #4382

BlackHole1 added a commit to BlackHole1/electron-builder that referenced this issue Nov 1, 2019
@Tomyail
Copy link

Tomyail commented Nov 4, 2019

I need this feature。 👏👏

develar pushed a commit that referenced this issue Nov 27, 2019
@stale
Copy link

stale bot commented Jan 3, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants