-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]: The pkg interface adds the must-close attribute #4380
Labels
Comments
BlackHole1
added a commit
to BlackHole1/electron-builder
that referenced
this issue
Nov 1, 2019
electron-userland#4380) Add mustClsoe key in pkg Identifies applications that must be closed before the package is installed. must-close: https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/DistributionDefinitionRef/Chapters/Distribution_XML_Ref.html#//apple_ref/doc/uid/TP40005370-CH100-SW77
I added the relevant PR: #4382 |
BlackHole1
added a commit
to BlackHole1/electron-builder
that referenced
this issue
Nov 1, 2019
electron-userland#4380) Add mustClsoe key in pkg Identifies applications that must be closed before the package is installed. must-close: https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/DistributionDefinitionRef/Chapters/Distribution_XML_Ref.html#//apple_ref/doc/uid/TP40005370-CH100-SW77 refactor(code-style): delete semicolon
I need this feature。 👏👏 |
develar
pushed a commit
that referenced
this issue
Nov 27, 2019
#4380) (#4382) Add mustClsoe key in pkg Identifies applications that must be closed before the package is installed. must-close: https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/DistributionDefinitionRef/Chapters/Distribution_XML_Ref.html#//apple_ref/doc/uid/TP40005370-CH100-SW77 refactor(code-style): delete semicolon
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version:
22.1.0
Target:
pkg
currently, some of the interfaces are provided when packaging the pkg application, but not all.
In the Apple developer documentation, there is a must-close attribute. I think this property is very necessary to join in.
Apple's introduction to
must-close
:Because the current
electron-builder
does not provide this property, it will not exit some apps that must be quit when installing pkg. You must usepostinstall
orpreinstall
to force the process to be killed. This is a very bad user check.The text was updated successfully, but these errors were encountered: