Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.2.1 Doesn't Include .node Files #468

Closed
vlad-shatskyi opened this issue Jun 3, 2016 · 3 comments · May be fixed by qcif/data-curator#563
Closed

4.2.1 Doesn't Include .node Files #468

vlad-shatskyi opened this issue Jun 3, 2016 · 3 comments · May be fixed by qcif/data-curator#563

Comments

@vlad-shatskyi
Copy link

I have a native dependency (https://github.com/chjj/pty.js/), which used to work in applications packaged by 4.2.0.

Currently the file build/Release/pty.node isn't included in the bundle. I'm not sure it's about it being .node, but I suspect that's the case because there were some changes to globbing

You can reproduce it by cloning https://github.com/shockone/black-screen and executing npm run pack. If you change the version in package.json to 4.2.1, the build will be broken.

@vlad-shatskyi vlad-shatskyi changed the title 4.2.1 Doesn't Include .node files 4.2.1 Doesn't Include .node Files Jun 3, 2016
@develar
Copy link
Member

develar commented Jun 3, 2016

Fix will be published in 15 minutes.

develar added a commit to develar/electron-builder that referenced this issue Jun 3, 2016
@develar
Copy link
Member

develar commented Jun 3, 2016

TODO: We must get rid of regexp ignore rules and use glob.

@develar develar closed this as completed in 12ba8b7 Jun 3, 2016
@vlad-shatskyi
Copy link
Author

You're very responsive @develar, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants