-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.2.1 Doesn't Include .node
Files
#468
Closed
Comments
.node
files.node
Files
Fix will be published in 15 minutes. |
develar
added a commit
to develar/electron-builder
that referenced
this issue
Jun 3, 2016
TODO: We must get rid of regexp ignore rules and use glob. |
You're very responsive @develar, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have a native dependency (https://github.com/chjj/pty.js/), which used to work in applications packaged by 4.2.0.
Currently the file
build/Release/pty.node
isn't included in the bundle. I'm not sure it's about it being.node
, but I suspect that's the case because there were some changes to globbingYou can reproduce it by cloning https://github.com/shockone/black-screen and executing
npm run pack
. If you change the version inpackage.json
to 4.2.1, the build will be broken.The text was updated successfully, but these errors were encountered: