Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub release names are now undefined #6819

Closed
adelphes opened this issue Apr 26, 2022 · 1 comment · Fixed by #6840
Closed

GitHub release names are now undefined #6819

adelphes opened this issue Apr 26, 2022 · 1 comment · Fixed by #6840

Comments

@adelphes
Copy link
Contributor

adelphes commented Apr 26, 2022

  • Electron-Builder Version: 23.0.3

I think this commit (related to this issue) has broken integrations that make use of release names.

On the GitHub website, an undefined release name gets displayed as the tag name - but the "real" name associated with the release is still undefined.
Common integrations that use the release name now look like this (Slack GitHub App for example):

Screenshot 2022-04-26 at 15 38 36

Prior to the change, they used to look like this:
Screenshot 2022-04-26 at 15 40 40

Can you revert the change or provide a way for setting the release name?

@mmaietta
Copy link
Collaborator

mmaietta commented May 1, 2022

Oh interesting! Happy to have it reverted, makes more sense that we'd want integrations to properly render release names. Would you mind opening a PR with the needed change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants