Don't set GitHub Releases draft title

[sindresorhus]

• Version: 20.38.5

• Target: macOS

When using auto-publishing to GitHub Releases, it creates a new release draft and sets the title to the version number. This is moot as GitHub will fall back to the tag name when no title is set, which is the version number.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[sindresorhus]

Please keep this open.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[sindresorhus]

Please keep this open.

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[sindresorhus]

Please keep this open.

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[sindresorhus]

Please keep this open.

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[sindresorhus]

Please keep this open.

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[sindresorhus]

Please keep this open.

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[sindresorhus]

Please keep this open.

[sindresorhus]

@stalebot We've been seeing each other for a while now. I think it's time you met my parents.

[LuKks]

We just need to remove line 210, right? name is optional: /v3/repos/releases/#create-a-release

electron-builder/packages/electron-publish/src/gitHubPublisher.ts

Lines 207 to 214 in 7b335db

	private createRelease() {
	return this.githubRequest<Release>(`/repos/${this.info.owner}/${this.info.repo}/releases`, this.token, {
	tag_name: this.tag,
	name: this.version,
	draft: this.releaseType === "draft",
	prerelease: this.releaseType === "prerelease",
	})
	}

createRelease is used here:

electron-builder/packages/electron-publish/src/gitHubPublisher.ts

Lines 133 to 139 in 7b335db

	if (this.options.publish === "always" || getCiTag() != null) {
	log.info({
	reason: "release doesn't exist",
	...logFields,
	}, `creating GitHub release`)
	return this.createRelease()
	}

Assuming that this.options.publish in always is the auto-publish option.

[sindresorhus]

Please keep this open.

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[sindresorhus]

Please keep this open.

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[sindresorhus]

Please keep this open.

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[sindresorhus]

Please keep this open.

[mmaietta]

Hi @sindresorhus , please give this a shot. You can use patch-package to always have this patch applied as a postinstall hook.
Filename electron-publish+22.10.5.patch

diff --git a/node_modules/electron-publish/out/gitHubPublisher.js b/node_modules/electron-publish/out/gitHubPublisher.js
index 75e5ca2..e24f0f7 100644
--- a/node_modules/electron-publish/out/gitHubPublisher.js
+++ b/node_modules/electron-publish/out/gitHubPublisher.js
@@ -273,7 +273,7 @@ class GitHubPublisher extends _publisher().HttpPublisher {
   createRelease() {
     return this.githubRequest(`/repos/${this.info.owner}/${this.info.repo}/releases`, this.token, {
       tag_name: this.tag,
-      name: this.version,
+      // name: this.version,
       draft: this.releaseType === "draft",
       prerelease: this.releaseType === "prerelease"
     });

That should deactivate the draft title per the earlier comment.

[sindresorhus]

Thanks, but it's not important enough to deal with patch-package. I just manually remove the title until this is properly fixed electron-builder.

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[sindresorhus]

Please keep this open.

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[sindresorhus]

Please keep this open.