Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add request.pause() to notification about progress #1077

Merged
merged 2 commits into from
Jan 3, 2017
Merged

fix: add request.pause() to notification about progress #1077

merged 2 commits into from
Jan 3, 2017

Conversation

maczikasz
Copy link
Contributor

See issue #1045

@mention-bot
Copy link

@maczikasz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @badams to be a potential reviewer.

@develar
Copy link
Member

develar commented Jan 3, 2017

cc @badams I think proper fix is to not listen data, but use pipe in the same way as we already use progress-stream for download.

@develar
Copy link
Member

develar commented Jan 3, 2017

To be clear — I don't insist and don't recommend to use progress-stream here to reduce external deps. So, probably approach like our DigestTransform should be used here.

@develar develar assigned develar and unassigned develar Jan 3, 2017
@develar develar self-requested a review January 3, 2017 13:52
Copy link
Member

@develar develar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not robust solution.

@maczikasz
Copy link
Contributor Author

ok will take a look how it's done

@maczikasz
Copy link
Contributor Author

@develar I pushed a new commit, did you mean like that?

Copy link
Member

@develar develar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge and publish new version soon (several hours). Thank you!

@develar develar merged commit 7fa56bc into electron-userland:master Jan 3, 2017
@develar
Copy link
Member

develar commented Jan 3, 2017

@maczikasz Thank you! 0.9.1 published with your fix.

@badams
Copy link
Contributor

badams commented Jan 3, 2017

@develar @maczikasz Nice work, this is a much cleaner solution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants