-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add request.pause() to notification about progress #1077
Conversation
@maczikasz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @badams to be a potential reviewer. |
cc @badams I think proper fix is to not listen |
To be clear — I don't insist and don't recommend to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not robust solution.
ok will take a look how it's done |
@develar I pushed a new commit, did you mean like that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge and publish new version soon (several hours). Thank you!
@maczikasz Thank you! 0.9.1 published with your fix. |
@develar @maczikasz Nice work, this is a much cleaner solution 👍 |
See issue #1045