Fix appindicator icons with snap build #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are your sure that it is safe to change CI failed due to outdated snapshots (please run snapTest with |
|
My understanding from the snap team is that it's safe for any graphical application like electron to always have this. I'll see if I can figure out the snapTest command. |
|
Why TMPDIR is not readable? Could you please explain? |
|
XDG_RUNTIME_DIR is set by |
|
So... it is more safe to change |
|
@develar thanks for merging! 👍 |
|
Release will be tomorrow morning CET. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1452
Credit to: @flexiondotorg for the exact fix 😄