Add support for additional certificate file #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akorchev, thanks for your PR! By analyzing the history of the files in this pull request, we identified @symbyte and @unindented to be potential reviewers. |
|
I think env will be better. Or not? |
|
I guess yes however I don't know how to support env as well. Using a file was easier to implement. |
|
Any chance of getting this merged? |
|
Today I retuned from vacation. I don't want to merge it as is, but I am going to add support for env and then merge. In 2 days. |
|
On other hand, you can use |
|
Will be released today evening CET. Thanks! |
|
No, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the need to add an additional certificate file via the
/ac|-acoption (similar to this SO question). This PR adds a newadditionalCertificateFileoption toWinBuildOptions.