Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use productName from app/package.json if present #204

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: use productName from app/package.json if present
tmm1 committed Mar 4, 2016

Verified

This commit was signed with the committer’s verified signature.
brandonkelly Brandon Kelly
commit 04999e305254cea17c8d2d1b174df006f9978dec
3 changes: 3 additions & 0 deletions src/packager.ts
Original file line number Diff line number Diff line change
@@ -55,6 +55,9 @@ export class Packager implements BuildInfo {
await BluebirdPromise.all(Array.from(new Set([buildPackageFile, appPackageFile]), readPackageJson))
.then(result => {
this.metadata = result[result.length - 1]
if (this.metadata.productName) {
this.metadata.name = this.metadata.productName
}
this.devMetadata = result[0]
this.checkMetadata(appPackageFile, platforms)

1 change: 1 addition & 0 deletions src/repositoryInfo.ts
Original file line number Diff line number Diff line change
@@ -22,6 +22,7 @@ export interface MetadataAuthor {
export interface AppMetadata extends Metadata {
version: string
name: string
productName: string
description: string
author: MetadataAuthor