Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nsis): respect --force-run when RUN_AFTER_FINISH is false #3093

Closed

Conversation

wojtkowiak
Copy link
Contributor

This is a follow up for:

#2951
#2974

oneClick: true,
runAfterFinish: false

My configuration is now working as expected but the auto update is not starting the app after the update.
Please take a look at it but it should now be ok for all cases.

@develar
Copy link
Member

develar commented Jul 10, 2018

Hmm... You want to build one-click installer that doesn't start app on finish, but electron-updater behaviour must be independent and allows you to start app if you pass corresponding flag....

Good catch. Makes sense. One correction — if RUN_AFTER_FINISH defined, we still need to respect isForceRun even if silent. I will merge with this correction.

@develar develar closed this in 3557aae Jul 10, 2018
@wojtkowiak
Copy link
Contributor Author

Thanks!

if RUN_AFTER_FINISH defined, we still need to respect isForceRun even if silent

Right, I've misinterpreted that conditional.

@mastergberry
Copy link
Contributor

Is this related to #2921 also?

@develar
Copy link
Member

develar commented Jul 11, 2018

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants