Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding dot asar option #496

Merged
merged 1 commit into from
Jun 14, 2016
Merged

Conversation

markgardner
Copy link
Contributor

This will allow users to have the ability to include dot folders into their asar file. This should maintain existing default functionality.

This will allow users to have the ability to include dot folders into
their asar file.
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @develar to be a potential reviewer

@develar
Copy link
Member

develar commented Jun 14, 2016

Could you please specify the reason why you have to do it? Name of required files? My plan is to get feedback and add explicit inclusion for such files (name starts with dot).

@develar develar merged commit 3fc7a89 into electron-userland:master Jun 14, 2016
@markgardner
Copy link
Contributor Author

We just keep our built files in a .build folder. It helps us keep the app directory clean when building locally

@develar
Copy link
Member

develar commented Jun 14, 2016

If I understand correctly — you build source js using Babel/TS to dir .build? Hmm.... You also have to modify files option, because dot files are ignored as well by default.

Ok, it seems yor setup is not common and it cannot be automatically discovered. Or maybe is there some way — field in the package.json, Babel config?

@markgardner
Copy link
Contributor Author

We have a homegrown asset management tool that is like webpack. We use that to create all of the minified release files.

We are doing a few custom things to build all of our assets that is definitely an edge case. We did modify the files array to include our build folder (that seemed pretty straight forward to me once I released how glob ignores dot folders by default).

Side Note, I started from scratch upgrading our complex build process for 0.36.0 that would call electron-packager directly. Using electron-builder is sooo much easier. Thank you for all you have done with this.

@develar
Copy link
Member

develar commented Jun 14, 2016

Please be aware that you should not just add pattern **/.*, you should add pattern .build. To ignore node_modules/.bin, . DS_Store and so on.

For asar it it doesn't matter because asar gets already filtered files (so, it is ok and safe to just enable dot files). Hmm... we are going in the future to get rid of intermediate copy and pack to asar directly, so, for now, I am not against your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants