fix(GitHubPublisher): add timeout to GitHub publisher uploads prevent socket hand up due to short timeout default setting fixes #4940

[Kellojo]

fix(GitHubPublisher): add timeout to GitHub publisher uploads

prevent socket hand up due to short timeout default setting

fixes #4940

[Kellojo]

Ideally this fixes #4940. I need help on testing this though.
Ideally I would like to test this directly in a CI environment (i.e. by installing electron-builder from the fork I created).
This does not seem to work though and fails with:

npm i git+https://github.com/Kellojo/electron-builder.git
npm ERR! premature close

npm ERR! A complete log of this run can be found in:

Does anybody have any ideas?

[mmaietta]

Thanks for the PR!

Copying this here from #4940 thread in case anyone else misses it:
https://github.com/electron-userland/electron-builder/blob/master/CONTRIBUTING.md#to-setup-a-local-dev-environment

[hovancik]

I believe the value should be configurable?

[mmaietta]

Based on this comment, it doesnt seem that increasing the timeout will resolve the issue, even when the value is something significantly larger (30s vs 240s)
#4940 (comment)

[Kellojo]

Back to the drawing board 😄