fix: Update certificate validation on Windows to check full DN

[devinbinnie]

This PR changes the certificate validation for NSIS installer to allow for validation of the entire DN instead of just the Common Name portion. This should allow for a more secure certificate validation.

[changeset-bot]

🦋 Changeset detected

Latest commit: 2526ab0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
electron-updater	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✔️ Deploy Preview for car-park-attendant-cleat-11576 ready!

🔨 Explore the source changes: 2526ab0

🔍 Inspect the deploy log: https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/61f02d3c304cbf0007fce684

😎 Browse the preview: https://deploy-preview-6576--car-park-attendant-cleat-11576.netlify.app

[devinbinnie]

@mmaietta Added as a draft for now because I've added a unit test for the new case, but the tests don't seem to pass on my machine (Windows 10 running Git Bash). I have my own certificate as well, and some of the snapshots don't match. Is there a test runner in CI I can use? Or is there some way to set up my dev environment such that I can get the tests to pass?

[mmaietta]

@mmaietta Added as a draft for now because I've added a unit test for the new case, but the tests don't seem to pass on my machine (Windows 10 running Git Bash). I have my own certificate as well, and some of the snapshots don't match. Is there a test runner in CI I can use? Or is there some way to set up my dev environment such that I can get the tests to pass?

All CI is now handled through GitHub Actions. The test snapshots are OS-specific and for some, such as publish/updating, they need to have an API key or token that are part of this repo's env secrets. All in all, it's really difficult to get a singular test environment. pnpm test-linux can cover the linux-based snapshots by running via docker. Other than that, the mapping of test files/snapshots to platform are:
Linux

electron-builder/.github/workflows/test.yaml

Lines 21 to 22 in 59b6bec

	- ArtifactPublisherTest,BuildTest,ExtraBuildTest,RepoSlugTest,binDownloadTest,configurationValidationTest,filenameUtilTest,filesTest,globTest,ignoreTest,macroExpanderTest,mainEntryTest,urlUtilTest,extraMetadataTest,linuxArchiveTest,linuxPackagerTest,HoistedNodeModuleTest,PublishManagerTest
	- snapTest,debTest,fpmTest,protonTest

MacOS

electron-builder/.github/workflows/test.yaml

Line 67 in 59b6bec

TEST_FILES: masTest,dmgTest,protonTest

MacOS (updater-specific due to env tokens)

electron-builder/.github/workflows/test.yaml

Line 86 in 59b6bec

TEST_FILES: nsisUpdaterTest

Windows

electron-builder/.github/workflows/test.yaml

Lines 97 to 98 in 59b6bec

	- installerTest,appxTest,msiTest,portableTest,assistedInstallerTest,protonTest
	- oneClickInstallerTest,winCodeSignTest,winPackagerTest,webInstallerTest

Depending on what OS I'm working on, I have to update snapshots by booting up my corresponding OS. For non-token-based tests, I think you can activate github actions on a fork of this repo?

[mmaietta]

All tests pass 🙌