-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add installDir property for NsisUpdater #6907
feat: Add installDir property for NsisUpdater #6907
Conversation
🦋 Changeset detectedLatest commit: 8468213 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
d543b02
to
7d700a5
Compare
7d700a5
to
b1b5431
Compare
I'm not sure if this is the correct location for an NSIS-only property. Would it perhaps be better to add to NsisUpdater.ts as a property there? |
1ed0972
to
f2e837e
Compare
I'm still not in favor of this PR as mentioned here: #6907 (comment) We shouldn't add os-specific properties to the base AppUpdater |
95e286d
to
8468213
Compare
@mmaietta Moved to NsisUpdater.ts |
Hi Mike, |
Add installDir property for NsisUpdater. Now is it posible change install folder from AppUpdater.
#6818