feat(nsis): add ShutdownBlockReasonCreate for blocking Win Shutdown prompt #7251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ShutdownBlockReasonCreate show better message why shutdown is blocked
🦋 Changeset detectedLatest commit: 5e44bac The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I don't know much about nsis scripting so I am not sure if it's a correct way to do it. But it works. |
|
Thanks for opening this PR! I'm not sure I understand it though. What business requirements/flow is this implementing for? Could you add more details to the PR description? |
|
I have added more details. I hope it's more clear now. |
mmaietta
changed the title
|
Thanks for the contribution! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want a user to undestand why they cannot shutdown a computer, because the installation process have not been completed yet.
On windows we can use ShutdownBlockReasonCreate to show a better message when shutdown is blocked instaed of default one.
Before
After