Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding node 18 docker images for electron-builder #7450

Merged

Conversation

xmireczech
Copy link
Contributor

Adding node 18 docker images for electron-builder (Electron 23 uses node 18).

@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2023

🦋 Changeset detected

Latest commit: 1c94e73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 27, 2023

Deploy Preview for car-park-attendant-cleat-11576 failed.

Name Link
🔨 Latest commit 6cf16dc
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/63fd0f2935454800075567eb

@netlify
Copy link

netlify bot commented Feb 27, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 1c94e73
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/64039f7e3acade0008b155fe
😎 Deploy Preview https://deploy-preview-7450--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@xmireczech xmireczech changed the title Adding node 18 docker images for electron-builder chore: Adding node 18 docker images for electron-builder Feb 27, 2023
@mmaietta
Copy link
Collaborator

mmaietta commented Mar 2, 2023

Can you please rebase off latest master? It seems there was a random integration test that started failing, causing all linux tests across PRs to fail.

@mmaietta mmaietta merged commit 22ee62a into electron-userland:master Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants