Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): adding msi and msi-wrapped to documentation site #7507

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

mmaietta
Copy link
Collaborator

Fixes: #7497

@changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2023

⚠️ No Changeset found

Latest commit: 14caae3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 27, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 14caae3
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6421b791ff81bf000828c6e1
😎 Deploy Preview https://deploy-preview-7507--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ItsHarper
Copy link
Contributor

ItsHarper commented Mar 27, 2023

Thanks! The msi documentation should probably call out #6683 and #6965 as significant issues, and mention that msiWrapped was added to work around them by making use of the much more battle-hardened NSIS target internally.

@ItsHarper
Copy link
Contributor

On second thought, I'm actually not completely sure if using msiWrapped works with auto-update.

@mmaietta
Copy link
Collaborator Author

@NoahAndrews , only nsis is supported with auto-update according to the docs

@ItsHarper
Copy link
Contributor

ItsHarper commented Mar 27, 2023

@NoahAndrews , only nsis is supported with auto-update according to the docs

True. Perhaps it's better to note that installations that were installed using the msiWrapped target can be updated using nsis (assuming that that's definitely true, which I'll be verifying soon).

@mmaietta
Copy link
Collaborator Author

mmaietta commented Mar 27, 2023

Please verify first 🙂 , I have no idea how msiWrapped works tbh. Just wanted to quickly solve your request for the docs to be more easily surfaced on the website

@mmaietta mmaietta merged commit b638c7f into master Apr 3, 2023
@mmaietta mmaietta deleted the feat/msi-wrapped-docs branch April 3, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

msi and msiwrapped targets need to be documented
2 participants