-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Include package-lock.json #192
Comments
The earlier version |
I still don't think that it should be in the |
Right now, the project contains only 8 dependencies. Remove |
You are right, you can submit a PR to remove |
putting |
Describe the bug
Adding the
package-lock.json
file to the.gitignore
is probably not what users of the template expect. Essentially, an Electron app is an application, and not a library. And with an application, one definitely wants to be able to recreate it anytime.However, if there's not package-lock.json, it's possible that some dependencies change, and suddenly, the previously-working application cannot be built anymore.
The text was updated successfully, but these errors were encountered: