Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document new release and versioning process #10336

Merged
merged 12 commits into from
Oct 7, 2017
Merged

document new release and versioning process #10336

merged 12 commits into from
Oct 7, 2017

Conversation

zeke
Copy link
Contributor

@zeke zeke commented Aug 23, 2017

This PR is an attempt to document our new (as of yet unused) strategy for doing pre-release versions of Electron. This content is optimistically projecting that we'll start using this approach with 1.8.0.

Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@vanessayuenn vanessayuenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since most visitors to this page probably care more about what major, minor, and patch mean in the context of electron, instead of what they mean in general, the Overview of Semantic Versioning section isn't as relevant as the rest of this document. Perhaps we can consider removing that section altogether, or at least move it under Electron Versioning and Prereleases?

@zeke
Copy link
Contributor Author

zeke commented Aug 23, 2017

Hey @vanessayuenn and @malept I made some updates based on your feedback. Let me know what you think.

Copy link
Contributor

@vanessayuenn vanessayuenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 lgtm

@zeke
Copy link
Contributor Author

zeke commented Aug 28, 2017

@vanessayuenn the new "distribution tags" section looks good to me.

@vanessayuenn vanessayuenn mentioned this pull request Aug 30, 2017
2 tasks
@rgbkrk
Copy link

rgbkrk commented Sep 3, 2017

Thank you so much for putting so much care into Electron and outlining this for Electron users. ❤️


A `dist-tag` can be used when installing Electron as a reference to a version instead of using a specific version number:

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the sh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @TiagoDanin. Fixed.

@zeke zeke changed the title document prereleases document new release and versioning process Sep 20, 2017
@zeke zeke changed the title document new release and versioning process [WIP] document new release and versioning process Sep 24, 2017
@zeke zeke force-pushed the document-prereleases branch from 1939d82 to 44572dc Compare October 4, 2017 19:05
@zeke zeke requested a review from a team October 4, 2017 19:05
@zeke zeke changed the title [WIP] document new release and versioning process document new release and versioning process Oct 4, 2017
@zeke
Copy link
Contributor Author

zeke commented Oct 4, 2017

Okay I've brought in @Tyriar's changes (thanks) and made some updates. This is now ready to go pending review from @tonyganch, @jkleinsc, and @vanessayuenn

Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

| Electron breaking API change | Major
| Electron non-breaking API change | Minor
| Electron bug fix | Patch
| Anything sufficiently "risky"\* | Major
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the note removed defined what risky meant (\*)? I can't see it.

@zeke
Copy link
Contributor Author

zeke commented Oct 5, 2017

@simurai if you have a spare moment to electronify that versions graphic, that would be 👌

@vanessayuenn
Copy link
Contributor

One small thing with the info displayed on the svg: beta versions actually have to start with 1, to adhere to the window FILEVERSION format that requires 4 numbers at all times (see this PR).

@zeke zeke requested a review from a team October 6, 2017 15:57
@vanessayuenn
Copy link
Contributor

I updated the documentation on the release process to reflect what I imagine the new process would be like, though I am sure crucial information is currently still missing from it. We can improve upon it after we have done the first release following the new versioning policy.

@zeke zeke merged commit 61e606b into master Oct 7, 2017
@zeke
Copy link
Contributor Author

zeke commented Oct 7, 2017

Thanks for updating releasing.md too, @vanessayuenn 👌

@zeke zeke deleted the document-prereleases branch October 7, 2017 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants