refactor(maker): replace zip-folder with cross-zip

ISSUES CLOSED: #322

package.json

@@ -104,6 +104,7 @@
     "bluebird": "^3.4.6",
     "colors": "^1.1.2",
     "commander": "^2.9.0",
+    "cross-zip": "^2.1.5",
     "debug": "^3.0.0",
     "electron-forge-template-angular2": "^1.0.3",
     "electron-forge-template-react": "^1.0.2",
@@ -132,8 +133,7 @@
     "sudo-prompt": "^7.0.0",
     "tabtab": "^2.2.1",
     "username": "^3.0.0",
-    "yarn-or-npm": "^2.0.2",
-    "zip-folder": "^1.0.0"
+    "yarn-or-npm": "^2.0.2"
   },
   "config": {
     "commitizen": {

src/makers/generic/zip.js

@@ -1,47 +1,17 @@
-import { spawn } from 'child_process';
 import path from 'path';
 import pify from 'pify';
+import { zip } from 'cross-zip';
 
 import { ensureFile } from '../../util/ensure-output';
 
 export const isSupportedOnCurrentPlatform = async () => true;
 
-const zipPromise = (from, to) =>
-  new Promise((resolve, reject) => {
-    const child = spawn('zip', ['-r', '-y', to, path.basename(from)], {
-      cwd: path.dirname(from),
-    });
-
-    child.stdout.on('data', () => {});
-    child.stderr.on('data', () => {});
-
-    child.on('close', (code) => {
-      if (code === 0) return resolve();
-      reject(new Error(`Failed to zip, exitted with code: ${code}`));
-    });
-  });
-
 export default async ({ dir, appName, targetPlatform, packageJSON }) => {
-  const zipFolder = require('zip-folder');
-
+  const zipDir = targetPlatform === 'darwin' ? path.resolve(dir, `${appName}.app`) : dir;
   const zipPath = path.resolve(dir, '../make', `${path.basename(dir)}-${packageJSON.version}.zip`);
+
   await ensureFile(zipPath);
-  switch (targetPlatform) {
-    // This case is tested but not on the coverage reporting platform
-    /* istanbul ignore next */
-    case 'win32':
-      await pify(zipFolder)(dir, zipPath);
-      break;
-    case 'darwin':
-      await zipPromise(path.resolve(dir, `${appName}.app`), zipPath);
-      break;
-    // This case is tested but not on the coverage reporting platform
-    /* istanbul ignore next */
-    case 'linux':
-      await zipPromise(dir, zipPath);
-      break;
-    default:
-      throw new Error('Unrecognized platform');
-  }
+  await pify(zip)(zipDir, zipPath);
+
   return [zipPath];
 };