fix(core): throw an error when no make targets for the given platform…

… are found (#1515)
electron · Feb 25, 2020 · bc370aa · bc370aa
1 parent 9f55a6c
commit bc370aa
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/packages/api/core/src/api/make.ts b/packages/api/core/src/api/make.ts
@@ -153,6 +153,10 @@ export default async ({
 
   targets = targets.filter((_, i) => makers[i]);
 
+  if (targets.length === 0) {
+    throw new Error(`Could not find any make targets configured for the "${actualTargetPlatform}" platform.`);
+  }
+
   info(interactive, `Making for the following targets: ${`${targets.map((t, i) => makers[i].name).join(', ')}`.cyan}`);
 
   const packageJSON = await readMutatedPackageJson(dir, forgeConfig);

diff --git a/packages/api/core/test/fixture/maker-wrong-platform.ts b/packages/api/core/test/fixture/maker-wrong-platform.ts
@@ -0,0 +1,3 @@
+export default class Maker {
+  platforms = ['win32'];
+}
diff --git a/packages/api/core/test/slow/api_spec_slow.ts b/packages/api/core/test/slow/api_spec_slow.ts
@@ -377,6 +377,17 @@ describe(`electron-forge API (with installer=${nodeInstaller})`, () => {
           })).to.eventually.be.rejectedWith(/incompatible with this version/);
         });
 
+        it('throws an error when no makers are configured for the given platform', async () => {
+          await expect(forge.make({
+            dir,
+            overrideTargets: [{
+              name: path.resolve(__dirname, '../fixture/maker-wrong-platform'),
+            }],
+            platform: 'linux',
+            skipPackage: true,
+          })).to.eventually.be.rejectedWith('Could not find any make targets configured for the "linux" platform.');
+        });
+
         it('can make for the MAS platform successfully', async () => {
           if (process.platform !== 'darwin') return;
           await expect(forge.make({